[PATCH] master.cfg: Add --prefix to libabigail multithreading configure options

Mark Wielaard mark@klomp.org
Thu Aug 27 12:44:33 GMT 2026


Hi Dodji,

On Thu, 2026-08-27 at 10:36 +0200, Dodji Seketeli wrote:
> When Libabigail is being configured for multithreading, it needs to
> know where to find the header files of elfutils.  It then tests if the
> _ELFUTILS_THREAD_SAFE macro is defined in those headers.  If it is,
> then Libabigail activates its multithreading features.  Otherwise, it
> does not.
> 
> For now, Libabigail assumes $prefix/include to be where to find those
> elfutils header files.
> 
> As the thread-safe version of elfutils is installed in $builddir/euts,
> this patch adds "--prefix=$builddir/euts" to the configure options of
> Libabigail's multithreading-enabled build.
> 
> The patch also adds some missing related comments.
> 
> Without this patch, Libabigail always falls back to being configured
> in single-threading mode, even with the
> libabigail-try-fedora-x86_64-mt builder.

Have you seen my review of the previous patch which touched on the same
topics?
https://inbox.sourceware.org/buildbot/20260826095346.GJ5046@gnu.wildebeest.org/

> Signed-off-by: Dodji Seketeli <dodji@seketeli.org>
> ---
>  builder/master.cfg | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/builder/master.cfg b/builder/master.cfg
> index a143f91..da46533 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -5039,7 +5039,12 @@ def libabigail_mt_combo_steps(build_name, configure_extra, tagsuffix):
>                  name="rm -rf " + build_name,
>                  haltOnFailure=True))
>          configure_cmd = ["../build/configure",
> +                         # Where to find elfutils header files install
> +                         # directory.
> +                         util.Interpolate("--prefix=%(prop:builddir)s/euts"),
> +                         # Where to find libdw.so
>                           util.Interpolate("--with-libdw=%(prop:builddir)s/euts"),
> +                         # Where to find libelf.so
>                           util.Interpolate("--with-elf=%(prop:builddir)s/euts"),
>                           "--enable-multithreading"] + list(configure_extra)
>          distcheck_flags = util.Interpolate(

So like with the previous patch, why do you need both --prefix and --
with-... ? Isn't --prefix normally used for where libabigail itself is
installed?

I think it would be good to understand why --with-elf or --with-libdw
cannot figure out where the libraries/pkgconf/header files are.

Thanks,

Mark


More information about the Buildbot mailing list