<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Alan,</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thank you for the feedback. I have sent a v2 of this patch with the correction. </div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hope to get approval and someone can commit this for us.</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks and regards,</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Aditya.</div>
<div style="direction: ltr; font-family: Aptos, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="mail-editor-reference-message-container">
<div class="ms-outlook-mobile-reference-message skipProofing">
<meta name="Generator" content="Microsoft Exchange Server">
</div>
<div style="padding: 3pt 0in 0in; border-width: 1pt medium medium; border-style: solid none none; border-color: rgb(181, 196, 223) currentcolor currentcolor;">
<div class="ms-outlook-mobile-reference-message skipProofing" style="text-align: left; font-family: Aptos; font-size: 12pt; color: black;">
<b>From: </b>Alan Modra <amodra@gmail.com><br>
<b>Date: </b>Thursday, 30 July 2026 at 5:07 AM<br>
<b>To: </b>Aditya Vidyadhar Kamath <akamath996@gmail.com><br>
<b>Cc: </b>binutils@sourceware.org <binutils@sourceware.org>; Aditya Kamath <Aditya.Kamath1@ibm.com>; SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com><br>
<b>Subject: </b>[EXTERNAL] Re: [PATCH v1] Add support to recognise 32 bit core file formats in AIX 7.3<br>
<br>
</div>
</div>
<div class="PlainText" style="font-size: 11pt;">On Tue, Jul 28, 2026 at 03:06:33PM +0530, Aditya Vidyadhar Kamath wrote:<br>
> diff --git a/bfd/rs6000-core.c b/bfd/rs6000-core.c<br>
> index 0635960eaee..7edf639fc9a 100644<br>
> --- a/bfd/rs6000-core.c<br>
> +++ b/bfd/rs6000-core.c<br>
<br>
This should likely be approved by one of the listed ppc binutils<br>
maintainers. I'm not an aix expert by any means. That said the patch<br>
looks OK to me with one small nit tidied.<br>
<br>
> @@ -151,7 +151,9 @@ typedef union<br>
> <br>
> #ifdef AIX_5_CORE<br>
> # define CORE_DUMPXX_VERSION 267312562<br>
> -# define CNEW_IS_CORE_DUMPXX(c) ((c).new_dump.c_version == CORE_DUMPXX_VERSION)<br>
> +# define CORE_DUMPXX_VERSION_AIX73 267312561<br>
> +# define CNEW_IS_CORE_DUMPXX(c) ((c).new_dump.c_version == CORE_DUMPXX_VERSION || \<br>
> + (c).new_dump.c_version == CORE_DUMPXX_VERSION_AIX73)<br>
<br>
Overlong lines, and trailing ||. Rewrite as<br>
# define CNEW_IS_CORE_DUMPXX(c) \<br>
((c).new_dump.c_version == CORE_DUMPXX_VERSION \<br>
|| (c).new_dump.c_version == CORE_DUMPXX_VERSION_AIX73)<br>
<br>
--<br>
Alan Modra<br>
</div>
</div>
</body>
</html>