bfd/ PR ld/13621 * bfd-in.h (_bfd_keep_sections_with_sym): New. * bfd-in2.h: Regnerated. * linker.c (keep_sections_with_sym): New. (_bfd_keep_sections_with_sym): Likewise. ld/ PR ld/13621 * ldlang.c (strip_excluded_output_sections): Call _bfd_keep_sections_with_sym if needed. ld/testsuite/ PR ld/13621 * ld-elf/zerosize1.d: New file. * ld-elf/zerosize1.s: Likewise. * ld-elf/zerosize1.t: Likewise. diff --git a/bfd/bfd-in.h b/bfd/bfd-in.h index bff5f34..8fe20bb 100644 --- a/bfd/bfd-in.h +++ b/bfd/bfd-in.h @@ -703,6 +703,9 @@ _bfd_nearby_section (bfd *, struct bfd_section *, bfd_vma); extern void _bfd_fix_excluded_sec_syms (bfd *, struct bfd_link_info *); +extern void _bfd_keep_sections_with_sym + (bfd *, struct bfd_link_info *); + extern unsigned bfd_m68k_mach_to_features (int); extern int bfd_m68k_features_to_mach (unsigned); diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h index a66c74f..cc8b380 100644 --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -710,6 +710,9 @@ _bfd_nearby_section (bfd *, struct bfd_section *, bfd_vma); extern void _bfd_fix_excluded_sec_syms (bfd *, struct bfd_link_info *); +extern void _bfd_keep_sections_with_sym + (bfd *, struct bfd_link_info *); + extern unsigned bfd_m68k_mach_to_features (int); extern int bfd_m68k_features_to_mach (unsigned); diff --git a/bfd/linker.c b/bfd/linker.c index 3caec96..50eab5e 100644 --- a/bfd/linker.c +++ b/bfd/linker.c @@ -3235,6 +3235,36 @@ _bfd_fix_excluded_sec_syms (bfd *obfd, struct bfd_link_info *info) bfd_link_hash_traverse (info->hash, fix_syms, obfd); } +/* Keep sections with symbols. */ + +static bfd_boolean +keep_sections_with_sym (struct bfd_link_hash_entry *h, void *data) +{ + bfd *obfd = (bfd *) data; + + if (h->type == bfd_link_hash_defined + || h->type == bfd_link_hash_defweak) + { + asection *s = h->u.def.section; + if (s != NULL + && (s->flags + & (SEC_LINKER_CREATED | SEC_EXCLUDE | SEC_KEEP)) == 0 + && s->output_section != NULL + && (s->output_section->flags + & (SEC_LINKER_CREATED | SEC_EXCLUDE | SEC_KEEP)) == 0 + && !bfd_section_removed_from_list (obfd, s->output_section)) + s->output_section->flags |= SEC_KEEP; + } + + return TRUE; +} + +void +_bfd_keep_sections_with_sym (bfd *obfd, struct bfd_link_info *info) +{ + bfd_link_hash_traverse (info->hash, keep_sections_with_sym, obfd); +} + /* FUNCTION bfd_generic_define_common_symbol diff --git a/ld/ldlang.c b/ld/ldlang.c index beb84d3..3e79ca0 100644 --- a/ld/ldlang.c +++ b/ld/ldlang.c @@ -3858,6 +3858,9 @@ strip_excluded_output_sections (void) lang_reset_memory_regions (); } + if (!link_info.relocatable) + _bfd_keep_sections_with_sym (link_info.output_bfd, &link_info); + for (os = &lang_output_section_statement.head->output_section_statement; os != NULL; os = os->next) diff --git a/ld/testsuite/ld-elf/zerosize1.d b/ld/testsuite/ld-elf/zerosize1.d new file mode 100644 index 0000000..36d1433 --- /dev/null +++ b/ld/testsuite/ld-elf/zerosize1.d @@ -0,0 +1,12 @@ +#source: start.s +#source: zerosize1.s +#ld: -T zerosize1.t +#readelf: -sS --wide + +# Check that xyzzy is not placed in the .text section. + +#... + \[[ 2]+\] zerosize[ \t]+PROGBITS[ \t0-9a-f]+WA.* +#... + +[0-9]+: +[0-9a-f]+ +0 +(OBJECT|NOTYPE) +GLOBAL +DEFAULT +2 xyzzy +#pass diff --git a/ld/testsuite/ld-elf/zerosize1.s b/ld/testsuite/ld-elf/zerosize1.s new file mode 100644 index 0000000..4fc8198 --- /dev/null +++ b/ld/testsuite/ld-elf/zerosize1.s @@ -0,0 +1,3 @@ + .section "zerosize","aw" + .globl xyzzy +xyzzy: diff --git a/ld/testsuite/ld-elf/zerosize1.t b/ld/testsuite/ld-elf/zerosize1.t new file mode 100644 index 0000000..0be32cd --- /dev/null +++ b/ld/testsuite/ld-elf/zerosize1.t @@ -0,0 +1,5 @@ +SECTIONS { + .text : { *(.text) } + zerosize : { *(zerosize) } + /DISCARD/ : { *(.*) } +}