[PATCH 1/7] x86: Support x86 AVX10_VPMLDSABFLYDQ instructions

Jan Beulich jbeulich@suse.com
Mon Nov 16 13:09:15 GMT 2026


On 16.11.2026 08:54, Haochen Jiang wrote:
> --- a/gas/NEWS
> +++ b/gas/NEWS
> @@ -1,5 +1,7 @@
>  -*- text -*-
>  
> +* Add support for the x86 AVX10_VPMLDSABFLYDQ instructions.

Nit: Singular?

> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -1273,6 +1273,8 @@ static const arch_entry cpu_arch[] =
>    SUBARCH (padlockphe2, PADLOCKPHE2, PADLOCKPHE2, false),
>    SUBARCH (padlockxmodx, PADLOCKXMODX, PADLOCKXMODX, false),
>    SUBARCH (movrs, MOVRS, MOVRS, false),
> +  VECARCH (avx10_vpmldsabflydq, AVX10_VPMLDSABFLYDQ, ANY_AVX10_VPMLDSABFLYDQ,
> +	   reset),

Maybe better add further up, next to other AVX10 ones?

> --- a/gas/doc/c-i386.texi
> +++ b/gas/doc/c-i386.texi
> @@ -235,6 +235,7 @@ accept various extension mnemonics.  For example,
>  @code{avx10.2/128},
>  @code{avx10v2aux},
>  @code{movrs},
> +@code{avx10_vpmldsabflydq},
>  @code{amx_int8},
>  @code{amx_bf16},
>  @code{amx_fp16},
> @@ -1735,6 +1736,7 @@ supported on the CPU specified.  The choices for @var{cpu_type} are:
>  @item @samp{.avx_vnni_int16} @tab @samp{.sha512} @tab @samp{.sm3} @tab @samp{.sm4}
>  @item @samp{.pbndkb} @tab @samp{.user_msr} @tab @samp{.msr_imm}
>  @item @samp{.avx_ifma} @tab @samp{.avx_vnni_int8} @tab @samp{.movrs}
> +@item @samp{.avx10_vpmldsabflydq}
>  @item @samp{.wbnoinvd} @tab @samp{.pconfig} @tab @samp{.waitpkg} @tab @samp{.cldemote}
>  @item @samp{.shstk} @tab @samp{.gfni} @tab @samp{.vaes} @tab @samp{.vpclmulqdq}
>  @item @samp{.movdiri} @tab @samp{.movdir64b} @tab @samp{.enqcmd} @tab @samp{.tsxldtrk}

Similarly here herhaps.

> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -253,6 +253,8 @@ static const dependency isa_dependencies[] =
>      "AVX10_1_AUX" },
>    { "AVX10_V2_AUX",
>      "AVX10_1" },
> +  { "AVX10_VPMLDSABFLYDQ",
> +    "AVX10_1" },
>    { "SEV_ES",
>      "SVME" },
>    { "SNP",
> @@ -466,6 +468,7 @@ static bitfield cpu_flags[] =
>    BITFIELD (AVX10_2),
>    BITFIELD (AVX10_V2_AUX),
>    BITFIELD (MOVRS),
> +  BITFIELD (AVX10_VPMLDSABFLYDQ),
>    BITFIELD (MWAITX),
>    BITFIELD (CLZERO),
>    BITFIELD (OSPKE),

And here, and ...

> --- a/opcodes/i386-opc.h
> +++ b/opcodes/i386-opc.h
> @@ -247,6 +247,8 @@ enum i386_cpu
>    CpuMSR_IMM,
>    /* Intel MOVRS Instructions support required.  */
>    CpuMOVRS,
> +  /* AVX10_VPMLDSABFLYDQ Instructions support required.  */
> +  CpuAVX10_VPMLDSABFLYDQ,
>    /* mwaitx instruction required */
>    CpuMWAITX,
>    /* Clzero instruction required */
> @@ -541,6 +543,7 @@ typedef union i386_cpu_flags
>        unsigned int cpuuser_msr:1;
>        unsigned int cpumsr_imm:1;
>        unsigned int cpumovrs:1;
> +      unsigned int cpuavx10_vpmldsabflydq:1;
>        unsigned int cpumwaitx:1;
>        unsigned int cpuclzero:1;
>        unsigned int cpuospke:1;

... both places here, and ...

> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
> @@ -3718,3 +3718,9 @@ vmovrs<bw>, 0xf26f, AVX10_2&MOVRS&x64, Modrm|Masking|Map5|<bw:vexw>|Disp8ShiftVL
>  vmovrs<dq>, 0xf36f, AVX10_2&MOVRS&x64, Modrm|Masking|Map5|<dq:vexw>|Disp8ShiftVL|CheckOperandSize|NoSuf, { Xmmword|Ymmword|Zmmword|Unspecified|BaseIndex, RegXMM|RegYMM|RegZMM }
>  
>  // MOVRS instructions end.
> +
> +// AVX10_VPMLDSABFLYDQ instructions.
> +
> +vpmldsabflydq, 0x66dc, AVX10_VPMLDSABFLYDQ, Modrm|Space0F3A|Src1VVVV|VexW1|Disp8ShiftVL|CheckOperandSize|NoSuf, { Imm8, RegXMM|RegYMM|RegZMM|Unspecified|BaseIndex, RegXMM|RegYMM|RegZMM, RegXMM|RegYMM|RegZMM }
> +
> +// AVX10_VPMLDSABFLYDQ instructions end.

... here as well.

Further, seeing how long AVX10_VPMLDSABFLYDQ is, and considering this is
really just a single insn, could we perhaps leave the AVX10 prefixes off
of internal identifiers? The connection to AVX10 would still be expressed
by the isa_dependencies[] entry (and the externally visible items).

Jan


More information about the Binutils mailing list