[PATCH v3 1/8] bfd: add _bfd_elf_relax_delete_range_ok
Jan Beulich
jbeulich@suse.com
Fri Nov 13 09:21:50 GMT 2026
On 13.11.2026 09:58, Harshit Kumar wrote:
>> Generally we permit format string to go past 80 cols, but ...
>> ... this one's really long (going to above 130). Still I'd like to suggest
>> shortening it some:
>>
>> (_("%pB: relax: cannot delete %" PRIu64 " bytes at %#" PRIx64
>> " (limit %#" PRIx64 ") in section `%pA' of size %#" PRIx64),
>>
>> This also improves the chances of a grep attempt actually hitting either
>> line. I can do this when committing, assuming you don't vehemently
>> disagree.
>
> No objection at all, thank you. One thing goes with it: the shared
> test helper ld_relax_underflow_test in 2/8 (ld/testsuite/lib/ld-lib.exp)
> accepts a rejection only if the output contains "bad relaxation", so with
> the new wording that match would need to become "*cannot delete*". I am
> happy to send an updated 2/8 if that is easier for you.
No need to, unless another reason arises.
> Separately, while re-checking the series I found that
> ft32_elf_relax_section's error_return returns true, the same problem
> 6/8 fixed for rl78, so a range-check failure on FT32 still lets the link
> succeed. I'll send a one-line follow-up patch for that instead of
> respinning the series.
That or call it 9/8.
Jan
More information about the Binutils
mailing list