[PATCH] VAX: PIC: Use GOT for pointer for global function
Alan Modra
amodra@gmail.com
Thu Nov 12 09:29:29 GMT 2026
On Sun, Nov 08, 2026 at 11:50:58AM +0100, Jan-Benedict Glaw wrote:
> On Mon, 2025-05-05 05:45:46 +0000, Rin Okuyama <rin@netbsd.org> wrote:
> > Subject: [PATCH] VAX: PIC: Use GOT for pointer for global function
> >
> > in same file, instead of PLT
> >
> > This fixes the problem reported as Bug 32941:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=32941
> >
> [...]
>
> > gas/config/tc-vax.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/gas/config/tc-vax.c b/gas/config/tc-vax.c
> > index 0b39d98f44a..529b25b9d57 100644
> > --- a/gas/config/tc-vax.c
> > +++ b/gas/config/tc-vax.c
> > @@ -409,8 +409,7 @@ md_estimate_size_before_relax (fragS *fragP, segT segment)
> > else if (((unsigned char *) fragP->fr_opcode)[0] == VAX_CALLS
> > || ((unsigned char *) fragP->fr_opcode)[0] == VAX_CALLG
> > || ((unsigned char *) fragP->fr_opcode)[0] == VAX_JSB
> > - || ((unsigned char *) fragP->fr_opcode)[0] == VAX_JMP
> > - || S_IS_FUNCTION (fragP->fr_symbol))
> > + || ((unsigned char *) fragP->fr_opcode)[0] == VAX_JMP)
> > reloc_type = BFD_RELOC_32_PLT_PCREL;
> > else
> > reloc_type = BFD_RELOC_32_GOT_PCREL;
>
> The patch is correct, but I think I cannot close the ticket?
Please commit, and I think you now should be able to update the PR.
--
Alan Modra
More information about the Binutils
mailing list