[PATCH] aarch64: Add FEAT_LSC64B assembly support

Alice Carlotti alice.carlotti@arm.com
Tue Nov 10 05:40:38 GMT 2026


On Fri, Oct 16, 2026 at 02:12:28PM +0000, Muhammad Kamran wrote:
> Add the +lsc64b architecture extension and the LSC64B instructions:
> 
> 	- LDA64B
> 	- STL64B
> 	- STL64BV
> 	- STL64BV0
> 
> FEAT_LSC64B implies FEAT_LSCP, while the LSC64B instructions also
> require FEAT_LS64.  Model this by making +lsc64b depend on +lscp and
> requiring both LSC64B and LS64 in the opcode feature set.
> 
> Reuse the existing LS64 Rt operand as FEAT_LSC64B shares the same operand
> constraints as FEAT_LS64.
> 
> Add assembler and disassembler tests for the new instructions, the Rt
> register restriction, the LS64 dependency, and the LSCP implication.
> ---
>  gas/config/tc-aarch64.c                    |   1 +
>  gas/doc/c-aarch64.texi                     |   2 +
>  gas/testsuite/gas/aarch64/lsc64b-invalid.d |   3 +
>  gas/testsuite/gas/aarch64/lsc64b-invalid.l |  81 ++++++++++++
>  gas/testsuite/gas/aarch64/lsc64b-invalid.s | 144 +++++++++++++++++++++
>  gas/testsuite/gas/aarch64/lsc64b.d         |  61 +++++++++
>  gas/testsuite/gas/aarch64/lsc64b.s         |  66 ++++++++++
>  include/opcode/aarch64.h                   |   4 +-
>  opcodes/aarch64-dis-2.c                    |  72 ++++++++---
>  opcodes/aarch64-tbl-2.h                    |   4 +
>  opcodes/aarch64-tbl.h                      |  10 ++
>  11 files changed, 431 insertions(+), 17 deletions(-)
>  create mode 100644 gas/testsuite/gas/aarch64/lsc64b-invalid.d
>  create mode 100644 gas/testsuite/gas/aarch64/lsc64b-invalid.l
>  create mode 100644 gas/testsuite/gas/aarch64/lsc64b-invalid.s
>  create mode 100644 gas/testsuite/gas/aarch64/lsc64b.d
>  create mode 100644 gas/testsuite/gas/aarch64/lsc64b.s
> 
> diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> index acd36d26f6b..0d382cc566e 100644
> --- a/gas/config/tc-aarch64.c
> +++ b/gas/config/tc-aarch64.c
> @@ -11114,6 +11114,7 @@ static const struct aarch64_option_cpu_value_table aarch64_features[] = {
>    {"f32mm",		AARCH64_FEATURE (F32MM), AARCH64_FEATURE (SVE)},
>    {"f64mm",		AARCH64_FEATURE (F64MM), AARCH64_FEATURE (SVE)},
>    {"ls64",		AARCH64_FEATURE (LS64), AARCH64_NO_FEATURES},
> +  {"lsc64b",		AARCH64_FEATURE (LSC64B), AARCH64_FEATURE (LSCP)},
>    {"flagm",		AARCH64_FEATURE (FLAGM), AARCH64_NO_FEATURES},
>    {"flagm2",		AARCH64_FEATURE (FLAGMANIP), AARCH64_FEATURE (FLAGM)},
>    {"pauth",		AARCH64_FEATURE (PAUTH), AARCH64_NO_FEATURES},
> diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi
> index 6a9fa2f98f3..303c14111db 100644
> --- a/gas/doc/c-aarch64.texi
> +++ b/gas/doc/c-aarch64.texi
> @@ -252,6 +252,8 @@ automatically cause those extensions to be disabled.
>   @tab Enable the 64 Byte Loads/Stores extensions.
>  @item @code{lscp} @tab
>   @tab Enable the load acquire and store release pair extension.
> +@item @code{lsc64b} @tab @code{lscp}
> + @tab Enable the 64 Byte Loads/Stores Consistency extension.

I think "64 byte load/store consistency instructions" would read better.  That
comment also applies to the existing ls64b description - that is, I think I
made the wording worse when I updated it a few years ago.  Feel free to update
them both.

>  @item @code{lse} @tab
>   @tab Enable Large System extensions.
>  @item @code{lse128} @tab @code{lse}
> diff --git a/gas/testsuite/gas/aarch64/lsc64b-invalid.d b/gas/testsuite/gas/aarch64/lsc64b-invalid.d
> new file mode 100644
> index 00000000000..7c4ff50cfdc
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/lsc64b-invalid.d
> @@ -0,0 +1,3 @@
> +#name: Atomic 64-byte load/store consistency instructions
> +#source: lsc64b-invalid.s
> +#error_output: lsc64b-invalid.l
> diff --git a/gas/testsuite/gas/aarch64/lsc64b-invalid.l b/gas/testsuite/gas/aarch64/lsc64b-invalid.l
> new file mode 100644
> index 00000000000..f6974e4e88d
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/lsc64b-invalid.l
> @@ -0,0 +1,81 @@
> +.*: Assembler messages:
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x1,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x3,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x5,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x7,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x9,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x11,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x13,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x15,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x17,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x19,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x21,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x23,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x24,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x25,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x26,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x27,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x28,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x29,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `lda64b x30,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x1,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x3,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x5,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x7,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x9,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x11,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x13,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x15,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x17,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x19,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x21,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x23,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x24,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x25,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x26,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x27,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x28,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x29,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 1 -- `stl64b x30,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x1,\[x2\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x3,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x5,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x7,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x9,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x11,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x13,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x15,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x17,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x19,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x21,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x23,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x24,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x25,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x26,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x27,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x28,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x29,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv x0,x30,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x1,\[x2\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x3,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x5,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x7,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x9,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x11,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x13,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x15,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x17,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x19,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x21,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x23,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x24,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x25,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x26,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x27,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x28,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x29,\[x1\]'
> +.*: Error: invalid Rt register number in 64-byte load/store at operand 2 -- `stl64bv0 x0,x30,\[x1\]'
> +.*: Error: selected processor does not support `lda64b x0,\[x1\]'
> +.*: Error: selected processor does not support `stl64b x0,\[x1\]'
> +.*: Error: selected processor does not support `stl64bv x1,x0,\[x2\]'
> +.*: Error: selected processor does not support `stl64bv0 x1,x0,\[x2\]'
> diff --git a/gas/testsuite/gas/aarch64/lsc64b-invalid.s b/gas/testsuite/gas/aarch64/lsc64b-invalid.s
> new file mode 100644
> index 00000000000..de71c2b7f77
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/lsc64b-invalid.s
> @@ -0,0 +1,144 @@
> +/* Atomic 64-byte load/store consistency instructions require Rt to be even
> +   and <= 22.  */
> +.arch armv9-a+ls64+lsc64b
> +
> +/* Single-copy Atomic 64-byte Load-acquire.  */
> +	lda64b x0, [x1]
> +	lda64b x1, [x1]
> +	lda64b x2, [x1]
> +	lda64b x3, [x1]
> +	lda64b x4, [x1]
> +	lda64b x5, [x1]
> +	lda64b x6, [x1]
> +	lda64b x7, [x1]
> +	lda64b x8, [x1]
> +	lda64b x9, [x1]
> +	lda64b x10, [x1]
> +	lda64b x11, [x1]
> +	lda64b x12, [x1]
> +	lda64b x13, [x1]
> +	lda64b x14, [x1]
> +	lda64b x15, [x1]
> +	lda64b x16, [x1]
> +	lda64b x17, [x1]
> +	lda64b x18, [x1]
> +	lda64b x19, [x1]
> +	lda64b x20, [x1]
> +	lda64b x21, [x1]
> +	lda64b x22, [x1]
> +	lda64b x23, [x1]
> +	lda64b x24, [x1]
> +	lda64b x25, [x1]
> +	lda64b x26, [x1]
> +	lda64b x27, [x1]
> +	lda64b x28, [x1]
> +	lda64b x29, [x1]
> +	lda64b x30, [x1]
> +
> +/* Single-copy Atomic 64-byte Store-release without Status Result.  */
> +	stl64b x0, [x1]
> +	stl64b x1, [x1]
> +	stl64b x2, [x1]
> +	stl64b x3, [x1]
> +	stl64b x4, [x1]
> +	stl64b x5, [x1]
> +	stl64b x6, [x1]
> +	stl64b x7, [x1]
> +	stl64b x8, [x1]
> +	stl64b x9, [x1]
> +	stl64b x10, [x1]
> +	stl64b x11, [x1]
> +	stl64b x12, [x1]
> +	stl64b x13, [x1]
> +	stl64b x14, [x1]
> +	stl64b x15, [x1]
> +	stl64b x16, [x1]
> +	stl64b x17, [x1]
> +	stl64b x18, [x1]
> +	stl64b x19, [x1]
> +	stl64b x20, [x1]
> +	stl64b x21, [x1]
> +	stl64b x22, [x1]
> +	stl64b x23, [x1]
> +	stl64b x24, [x1]
> +	stl64b x25, [x1]
> +	stl64b x26, [x1]
> +	stl64b x27, [x1]
> +	stl64b x28, [x1]
> +	stl64b x29, [x1]
> +	stl64b x30, [x1]
> +
> +
> +/* Single-copy Atomic 64-byte Store-release with Status Result.  */
> +	stl64bv x1, x0,  [x2]
> +	stl64bv x0, x1,  [x2]
> +	stl64bv x0, x2,  [x1]
> +	stl64bv x0, x3,  [x1]
> +	stl64bv x0, x4,  [x1]
> +	stl64bv x0, x5,  [x1]
> +	stl64bv x0, x6,  [x1]
> +	stl64bv x0, x7,  [x1]
> +	stl64bv x0, x8,  [x1]
> +	stl64bv x0, x9,  [x1]
> +	stl64bv x0, x10, [x1]
> +	stl64bv x0, x11, [x1]
> +	stl64bv x0, x12, [x1]
> +	stl64bv x0, x13, [x1]
> +	stl64bv x0, x14, [x1]
> +	stl64bv x0, x15, [x1]
> +	stl64bv x0, x16, [x1]
> +	stl64bv x0, x17, [x1]
> +	stl64bv x0, x18, [x1]
> +	stl64bv x0, x19, [x1]
> +	stl64bv x0, x20, [x1]
> +	stl64bv x0, x21, [x1]
> +	stl64bv x0, x22, [x1]
> +	stl64bv x0, x23, [x1]
> +	stl64bv x0, x24, [x1]
> +	stl64bv x0, x25, [x1]
> +	stl64bv x0, x26, [x1]
> +	stl64bv x0, x27, [x1]
> +	stl64bv x0, x28, [x1]
> +	stl64bv x0, x29, [x1]
> +	stl64bv x0, x30, [x1]
> +
> +
> +/* Single-copy Atomic 64-byte EL0 Store-release with Status Result.  */
> +	stl64bv0 x1, x0,  [x2]
> +	stl64bv0 x0, x1,  [x2]
> +	stl64bv0 x0, x2,  [x1]
> +	stl64bv0 x0, x3,  [x1]
> +	stl64bv0 x0, x4,  [x1]
> +	stl64bv0 x0, x5,  [x1]
> +	stl64bv0 x0, x6,  [x1]
> +	stl64bv0 x0, x7,  [x1]
> +	stl64bv0 x0, x8,  [x1]
> +	stl64bv0 x0, x9,  [x1]
> +	stl64bv0 x0, x10, [x1]
> +	stl64bv0 x0, x11, [x1]
> +	stl64bv0 x0, x12, [x1]
> +	stl64bv0 x0, x13, [x1]
> +	stl64bv0 x0, x14, [x1]
> +	stl64bv0 x0, x15, [x1]
> +	stl64bv0 x0, x16, [x1]
> +	stl64bv0 x0, x17, [x1]
> +	stl64bv0 x0, x18, [x1]
> +	stl64bv0 x0, x19, [x1]
> +	stl64bv0 x0, x20, [x1]
> +	stl64bv0 x0, x21, [x1]
> +	stl64bv0 x0, x22, [x1]
> +	stl64bv0 x0, x23, [x1]
> +	stl64bv0 x0, x24, [x1]
> +	stl64bv0 x0, x25, [x1]
> +	stl64bv0 x0, x26, [x1]
> +	stl64bv0 x0, x27, [x1]
> +	stl64bv0 x0, x28, [x1]
> +	stl64bv0 x0, x29, [x1]
> +	stl64bv0 x0, x30, [x1]

These tests feel a little excessive to me, but it's fine to keep them as they
are.

> +
> +/* Omit +ls64 in .arch.  */
> +.arch armv9-a+lsc64b
> +	lda64b x0, [x1]
> +	stl64b x0, [x1]
> +	stl64bv x1, x0, [x2]
> +	stl64bv0 x1, x0, [x2]
> diff --git a/gas/testsuite/gas/aarch64/lsc64b.d b/gas/testsuite/gas/aarch64/lsc64b.d
> new file mode 100644
> index 00000000000..0212eb33144
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/lsc64b.d
> @@ -0,0 +1,61 @@
> +#name: LSC64B instructions
> +#objdump: -dr
> +
> +.*:     file format .*
> +
> +Disassembly of section \.text:
> +
> +0+ <.*>:
> +.*:	f8bfd020 	lda64b	x0, \[x1\]
> +.*:	f8bfd020 	lda64b	x0, \[x1\]
> +.*:	f8bfd022 	lda64b	x2, \[x1\]
> +.*:	f8bfd024 	lda64b	x4, \[x1\]
> +.*:	f8bfd026 	lda64b	x6, \[x1\]
> +.*:	f8bfd028 	lda64b	x8, \[x1\]
> +.*:	f8bfd02a 	lda64b	x10, \[x1\]
> +.*:	f8bfd02c 	lda64b	x12, \[x1\]
> +.*:	f8bfd02e 	lda64b	x14, \[x1\]
> +.*:	f8bfd030 	lda64b	x16, \[x1\]
> +.*:	f8bfd032 	lda64b	x18, \[x1\]
> +.*:	f8bfd034 	lda64b	x20, \[x1\]
> +.*:	f8bfd036 	lda64b	x22, \[x1\]
> +.*:	f87f9020 	stl64b	x0, \[x1\]
> +.*:	f87f9020 	stl64b	x0, \[x1\]
> +.*:	f87f9022 	stl64b	x2, \[x1\]
> +.*:	f87f9024 	stl64b	x4, \[x1\]
> +.*:	f87f9026 	stl64b	x6, \[x1\]
> +.*:	f87f9028 	stl64b	x8, \[x1\]
> +.*:	f87f902a 	stl64b	x10, \[x1\]
> +.*:	f87f902c 	stl64b	x12, \[x1\]
> +.*:	f87f902e 	stl64b	x14, \[x1\]
> +.*:	f87f9030 	stl64b	x16, \[x1\]
> +.*:	f87f9032 	stl64b	x18, \[x1\]
> +.*:	f87f9034 	stl64b	x20, \[x1\]
> +.*:	f87f9036 	stl64b	x22, \[x1\]
> +.*:	f861b040 	stl64bv	x1, x0, \[x2\]
> +.*:	f860b042 	stl64bv	x0, x2, \[x2\]
> +.*:	f860b044 	stl64bv	x0, x4, \[x2\]
> +.*:	f860b046 	stl64bv	x0, x6, \[x2\]
> +.*:	f860b048 	stl64bv	x0, x8, \[x2\]
> +.*:	f860b04a 	stl64bv	x0, x10, \[x2\]
> +.*:	f860b04c 	stl64bv	x0, x12, \[x2\]
> +.*:	f860b04e 	stl64bv	x0, x14, \[x2\]
> +.*:	f860b050 	stl64bv	x0, x16, \[x2\]
> +.*:	f860b052 	stl64bv	x0, x18, \[x2\]
> +.*:	f860b054 	stl64bv	x0, x20, \[x2\]
> +.*:	f860b056 	stl64bv	x0, x22, \[x2\]
> +.*:	f861a040 	stl64bv0	x1, x0, \[x2\]
> +.*:	f860a042 	stl64bv0	x0, x2, \[x2\]
> +.*:	f860a044 	stl64bv0	x0, x4, \[x2\]
> +.*:	f860a046 	stl64bv0	x0, x6, \[x2\]
> +.*:	f860a048 	stl64bv0	x0, x8, \[x2\]
> +.*:	f860a04a 	stl64bv0	x0, x10, \[x2\]
> +.*:	f860a04c 	stl64bv0	x0, x12, \[x2\]
> +.*:	f860a04e 	stl64bv0	x0, x14, \[x2\]
> +.*:	f860a050 	stl64bv0	x0, x16, \[x2\]
> +.*:	f860a052 	stl64bv0	x0, x18, \[x2\]
> +.*:	f860a054 	stl64bv0	x0, x20, \[x2\]
> +.*:	f860a056 	stl64bv0	x0, x22, \[x2\]
> +.*:	d940581f 	ldap	xzr, x0, \[x0\]
> +.*:	d940781f 	ldapp	xzr, x0, \[x0\]
> +.*:	d9005800 	stlp	x0, x0, \[x0\]
> diff --git a/gas/testsuite/gas/aarch64/lsc64b.s b/gas/testsuite/gas/aarch64/lsc64b.s
> new file mode 100644
> index 00000000000..c9b4624b685
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/lsc64b.s
> @@ -0,0 +1,66 @@
> +/* Atomic 64-byte load/store consistency instructions.  */
> +.arch armv9-a+ls64+lsc64b
> +
> +/* Single-copy Atomic 64-byte Load-acquire.  */
> +	lda64b x0, [x1]
> +	lda64b x0, [x1, #0]
> +	lda64b x2, [x1]
> +	lda64b x4, [x1]
> +	lda64b x6, [x1]
> +	lda64b x8, [x1]
> +	lda64b x10, [x1]
> +	lda64b x12, [x1]
> +	lda64b x14, [x1]
> +	lda64b x16, [x1]
> +	lda64b x18, [x1]
> +	lda64b x20, [x1]
> +	lda64b x22, [x1]
> +
> +/* Single-copy Atomic 64-byte Store-release without Status Result.  */
> +	stl64b x0, [x1]
> +	stl64b x0, [x1, 0]
> +	stl64b x2, [x1]
> +	stl64b x4, [x1]
> +	stl64b x6, [x1]
> +	stl64b x8, [x1]
> +	stl64b x10, [x1]
> +	stl64b x12, [x1]
> +	stl64b x14, [x1]
> +	stl64b x16, [x1]
> +	stl64b x18, [x1]
> +	stl64b x20, [x1]
> +	stl64b x22, [x1]
> +
> +/* Single-copy Atomic 64-byte Store-release with Status Result.  */
> +	stl64bv x1, x0, [x2]
> +	stl64bv x0, x2, [x2]
> +	stl64bv x0, x4, [x2]
> +	stl64bv x0, x6, [x2]
> +	stl64bv x0, x8, [x2]
> +	stl64bv x0, x10, [x2]
> +	stl64bv x0, x12, [x2]
> +	stl64bv x0, x14, [x2]
> +	stl64bv x0, x16, [x2]
> +	stl64bv x0, x18, [x2]
> +	stl64bv x0, x20, [x2]
> +	stl64bv x0, x22, [x2]
> +
> +/* Single-copy Atomic 64-byte EL0 Store-release with Status Result.  */
> +	stl64bv0 x1, x0, [x2]
> +	stl64bv0 x0, x2, [x2]
> +	stl64bv0 x0, x4, [x2]
> +	stl64bv0 x0, x6, [x2]
> +	stl64bv0 x0, x8, [x2]
> +	stl64bv0 x0, x10, [x2]
> +	stl64bv0 x0, x12, [x2]
> +	stl64bv0 x0, x14, [x2]
> +	stl64bv0 x0, x16, [x2]
> +	stl64bv0 x0, x18, [x2]
> +	stl64bv0 x0, x20, [x2]
> +	stl64bv0 x0, x22, [x2]

These tests don't exercise all variable bits of the address argument. This
could be resolved by having at least an [x0] and an [sp] case for each
instruction.  Similarly, Rs could use an x0 and an xzr case for each
instruction.

I also think it's unnecessary to test every possible value of the Rt_LS64
operand, but there's little harm in doing so.  (If I were writing these tests
myself, I'd use something like x0, x14 and x22, to ensure all variable bits take
both values without using more cases than necessary).

> +
> +/* Check that +lsc64b enables FEAT_LSCP without an explicit +lscp.  */
> +.arch armv9-a+lsc64b
> +	ldap xzr, x0, [x0]
> +	ldapp xzr, x0, [x0]
> +	stlp x0, x0, [x0]



Looks good otherwise.

Alice


More information about the Binutils mailing list