[PATCH] gas: Mark weak functions as external in DWARF

Jan Beulich jbeulich@suse.com
Fri Nov 6 09:00:13 GMT 2026


On 05.11.2026 04:43, Longjun Luo wrote:
> --- a/gas/dwarf2dbg.c
> +++ b/gas/dwarf2dbg.c
> @@ -2753,7 +2753,7 @@ out_debug_abbrev (segT abbrev_seg,
>  	  continue;
>  #endif
>  
> -	  if (S_IS_EXTERNAL (symp))
> +	  if (S_IS_EXTERNAL (symp) || S_IS_WEAK (symp))
>  	    have_efunc = true;
>  	  else
>  	    have_lfunc = true;
> @@ -2978,7 +2978,7 @@ out_debug_info (segT info_seg, segT abbrev_seg, segT line_seg, segT str_seg,
>  
>  	  /* DW_AT_external.  */
>  	  if (func_form == DW_FORM_flag)
> -	    out_byte (S_IS_EXTERNAL (symp));
> +	    out_byte (S_IS_EXTERNAL (symp) || S_IS_WEAK (symp));
>  
>  	  /* PR 29517: Let consumers know that we do not have
>  	     return type information for this function.  */

This part certainly is okay, but ...

> --- /dev/null
> +++ b/gas/testsuite/gas/elf/dwarf-3-func-weak.d
> @@ -0,0 +1,37 @@
> +#as: --gdwarf-3
> +#name: Dwarf3 weak function debug info
> +#readelf: -W -wai
> +#target: i?86-*-* x86_64-*-*
> +
> +Contents of the .debug_info section:
> +
> + +Compilation Unit @ offset (0x)?0:
> + +Length: .*
> + +Version: +3
> + +Abbrev Offset: +(0x)?0
> + +Pointer Size: .*
> +#...
> + <0><[0-9a-f]+>: Abbrev Number: 1 \(DW_TAG_compile_unit\)
> +#...
> + <1><[0-9a-f]+>: Abbrev Number: 2 \(DW_TAG_subprogram\)
> + +<[0-9a-f]+> +DW_AT_name +: \(strp\) \(offset: (0x)?[0-9a-f]+\): wfunc
> + +<[0-9a-f]+> +DW_AT_external +: \(flag\) 1
> + +<[0-9a-f]+> +DW_AT_type +: \(ref_udata\) <0x[0-9a-f]+>
> + +<[0-9a-f]+> +DW_AT_low_pc +: \(addr\) (0x)?0
> + +<[0-9a-f]+> +DW_AT_high_pc +: \(addr\) (0x)?1
> + <1><[0-9a-f]+>: Abbrev Number: 3 \(DW_TAG_unspecified_type\)
> + <1><[0-9a-f]+>: Abbrev Number: 0
> +
> +Contents of the .debug_abbrev section:
> +
> + +Number TAG \((0x)?0\)
> + +1 +DW_TAG_compile_unit +\[has children\]
> +#...
> + +2 +DW_TAG_subprogram +\[no children\]
> + +DW_AT_name +DW_FORM_strp
> + +DW_AT_external +DW_FORM_flag
> + +DW_AT_type +DW_FORM_ref_udata
> + +DW_AT_low_pc +DW_FORM_addr
> + +DW_AT_high_pc +DW_FORM_addr
> + +DW_AT value: 0 +DW_FORM value: 0
> +#pass
> --- /dev/null
> +++ b/gas/testsuite/gas/elf/dwarf-3-func-weak.s
> @@ -0,0 +1,7 @@
> +	.text
> +
> +wfunc:
> +	.nop
> +	.weak wfunc
> +	.type wfunc, %function
> +	.size wfunc, .-wfunc

... what does this new testcase test which ...

> --- a/gas/testsuite/gas/elf/dwarf-3-func.d
> +++ b/gas/testsuite/gas/elf/dwarf-3-func.d
> @@ -37,6 +37,12 @@ Contents of the .debug_info section:
>   +<[0-9a-f]+> +DW_AT_type +: \(ref_udata\) <0x[0-9a-f]+>
>   +<[0-9a-f]+> +DW_AT_low_pc +: \(addr\) (0x)?35
>   +<[0-9a-f]+> +DW_AT_high_pc +: \(addr\) (0x)?38
> + <1><[0-9a-f]+>: Abbrev Number: 2 \(DW_TAG_subprogram\)
> + +<[0-9a-f]+> +DW_AT_name +: \(strp\) \(offset: (0x)?[0-9a-f]+\): wfunc
> + +<[0-9a-f]+> +DW_AT_external +: \(flag\) 1
> + +<[0-9a-f]+> +DW_AT_type +: \(ref_udata\) <0x[0-9a-f]+>
> + +<[0-9a-f]+> +DW_AT_low_pc +: \(addr\) (0x)?38
> + +<[0-9a-f]+> +DW_AT_high_pc +: \(addr\) (0x)?39
>   <1><[0-9a-f]+>: Abbrev Number: 3 \(DW_TAG_unspecified_type\)
>   <1><[0-9a-f]+>: Abbrev Number: 0
>  
> --- a/gas/testsuite/gas/elf/dwarf-3-func.s
> +++ b/gas/testsuite/gas/elf/dwarf-3-func.s
> @@ -37,4 +37,12 @@ lfunc2:
>  	.nop
>  	.type lfunc2, %function
>  	.size lfunc2, .-lfunc2
> +
> +	.ifndef LOCAL
> +wfunc:
> +	.nop
> +	.weak wfunc
> +	.type wfunc, %function
> +	.size wfunc, .-wfunc
> +	.endif
>  	.endif

... this adjustment to the existing one doesn't cover? (Same for the Dwarf5
ones below then, obviously.)

Jan


More information about the Binutils mailing list