[PATCH v2] x86/disasm: do not use format string without format specifiers
Will Hawkins
hawkinsw@obs.cr
Sun May 24 03:06:17 GMT 2026
Fixes build failure with -Werror=format-security on i686.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34168
Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
---
v2: Update commit message to reference Bugzilla
opcodes/i386-dis.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 1faf1fa7785..db1e4f7a7d5 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -10375,7 +10375,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
for (i = 0; i < MAX_OPERANDS; i++)
if (ins.op_index[i] != -1 && ins.op_riprel[i])
{
- i386_dis_printf (info, dis_style_comment_start, sep);
+ i386_dis_printf (info, dis_style_comment_start, "%s", sep);
sep = ", ";
(*info->print_address_func)
((bfd_vma)(ins.start_pc + (ins.codep - ins.start_codep)
@@ -10384,11 +10384,11 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
}
else if (*ins.cm_out[i])
{
- i386_dis_printf (info, dis_style_comment_start, sep);
+ i386_dis_printf (info, dis_style_comment_start, "%s", sep);
sep = ", ";
i386_dis_printf (info, dis_style_symbol, "%s", ins.cm_out[i]);
}
-
+
ret = ins.codep - priv.the_buffer;
out:
info->private_data = NULL;
--
2.49.0
More information about the Binutils
mailing list