[PATCH 4/6] Aarch64/Haiku/binutils/testsuite: Suppress PEI test
Maciej W. Rozycki
macro@orcam.me.uk
Sat May 9 14:42:11 GMT 2026
On Sun, 5 Apr 2026, Jan Beulich wrote:
> > There's no PEI BFD target included with the Haiku target configuration,
>
> Would you mind adding "by default", as people could always enable it as
> secondary target?
Sure, good point, done.
> > --- binutils-gdb.orig/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
> > +++ binutils-gdb/binutils/testsuite/binutils-all/aarch64/pei-aarch64-little.d
> > @@ -3,6 +3,8 @@
> > #PROG: objcopy
> > #objcopy: -j .text -j .sdata -j .data -j .dynamic -j .dynsym -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* -j .reloc --output-target=efi-app-aarch64
> > #objdump: -h -f
> > +# No `pei-aarch64-little' target support for Haiku.
> > +#notarget: *-*-haiku*
>
> I understand you're only after the one target, yet it looks like if already
> we're excluding targets here, we might as well add a more complete exclusion
> list (as per bfd/config.bfd)?
Given your observation above it seems asking for a feature test, so that
this and any other cases that depend on a secondary target are actually
run iff supported and not based on a fixed target list. To avoid the risk
of getting sidetracked into secondary tasks while I have fires to put out
I'm not going to implement this at this time. This single exclusion seems
good enough for the problem at hand.
Thank you for your review, I have applied this change now.
Maciej
More information about the Binutils
mailing list