RFC: Annotate immediates in x86 disassembly

Jan Beulich jbeulich@suse.com
Fri May 8 13:20:30 GMT 2026


On 23.04.2026 13:03, Nick Clifton wrote:
> Hi Guys,
> 
>    Attached is a v2 of the proposed patch.  It adds:
> 
>    * The annotation is displayed as a comment at the end of the line.
>    * The symbol name is displayed in dis_style_symbol rather than dis_style_address.
>    * Shared object files (type ET_DYN) can also benefit from the new feature.
> 
>    There are a couple of potential issues with the patch:
> 
>    * It adds a new buffer to the instr_info structure, making it even bigger.
>    * There are opportunities for sharing code with the oappend_*() functions
>      which I did not take.  (Mainly to keep the code in the patch simple).
>    * There are opportunities for other places in the dissaembler to add comments
>      of their own, but I figured that these could be added later, if they
>      were actually deemed worthwhile.
> 
>    Thoughts, comments ?

For me the use of the global "exe" in test_objdump_M_annotate is a
problem when running the testsuite with RUNTESTFLAGS=x86-64.exp:
ERROR: can't read "exe": no such variable

Sadly I have no clue what may need doing to address this.

Jan


More information about the Binutils mailing list