[PATCH v3] s390: Do not use canonical PLT if pointer equality is not needed
Jens Remus
jremus@linux.ibm.com
Thu Mar 19 16:59:00 GMT 2026
Hello Alan,
thanks a lot for your detailed explanation! This is much appreciated!
On 3/19/2026 6:42 AM, Alan Modra wrote:
> On Tue, Mar 17, 2026 at 05:29:52PM +0100, Jens Remus wrote:
>> +# PR 29655 (cont.): Check that in PIC code linked as PDE taking the address
>> +# of a function defined in a DSO results in the function address (from GOT)
>> +# and not the "canonical PLT" address from the PDE.
>> +# This is just an optimization and both is valid, although libraries may
>> +# depend on this specific behavior, so do not complain loudly.
>> +setup_xfail *-*-*
>> +clear_xfail aarch64-*-* alpha-*-* arm*-*-* hppa-*-* i?86-*-* ia64-*-* \
>> + microblaze-*-* mips-*-* mips64-*-* powerpc*-*-* s390x-*-* x86_64-*-*
>
> I think you should delete the preceding five lines, leaving it up to
> target maintainers to add setup_xfail for their targets. No need to
> repost with just that changed. The comment here is a little
> misleading. This isn't just an optimisation, but rather about
> generating a correct program.
Ok. Thank you for the approval (for adding the common test)!
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303)
jremus@de.ibm.com / jremus@linux.ibm.com
IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Ehningen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
More information about the Binutils
mailing list