[PATCH v2 2/4] i386: add i386-phoenix target

Jan Beulich jbeulich@suse.com
Thu Mar 19 08:15:51 GMT 2026


On 13.03.2026 17:26, Michal Lach wrote:
> Jan Beulich <jbeulich@suse.com> writes:
> 
>> On 10.03.2026 20:02, Michał Lach wrote:
>>> --- a/bfd/config.bfd
>>> +++ b/bfd/config.bfd
>>> @@ -785,6 +785,9 @@ case "${targ}" in
>>>      targ_defvec=i386_elf32_vxworks_vec
>>>      targ_underscore=yes
>>>      ;;
>>> +  i[3-6]86-*-phoenix*)
>>> +    targ_defvec=i386_elf32_vec
>>> +    ;;
>>
>> A little further up there already is
>>
>>   i[3-7]86-*-aros* | i[3-7]86-*-gnu* | i[3-7]86-*-openbsd*)
>>     targ_defvec=i386_elf32_vec
>>     ;;
>>
>> Would be nice if you added phoenix into there.
> 
> Huh, I just pulled upstream master and I see i[3-7]86-*-aros* having
> a separate entry,

Oh, I overlooked that the folding is the result of a pending patch of
mine.

> I could fold them into one but we have not really
> tested builds with Intel Quark microarch enabled,

I fear I don't see what concern you have there.

> so I'd prefer for
> this code to stay the way it is.
> 
>>
>>> --- a/ld/configure.tgt
>>> +++ b/ld/configure.tgt
>>> @@ -431,6 +431,8 @@ i[3-7]86-*-haiku*)	targ_emul=elf_i386_haiku
>>>  			;;
>>>  i[3-7]86-*-vxworks*)	targ_emul=elf_i386_vxworks
>>>  			;;
>>> +i[3-6]86-*-phoenix*)	targ_emul=elf_i386
>>> +			;;
>>>  i[3-7]86-*-chaos)	targ_emul=elf_i386_chaos
>>>  			;;
>>
>> Somewhat similarly here, we already have
>>
>> i[3-7]86-*-netbsd* | \
>> i[3-7]86-*-netbsd*-gnu* | \
>> i[3-7]86-*-knetbsd*-gnu | \
>> i[3-7]86-*-openbsd*)
>> 			targ_emul=elf_i386
>> 			;;
>>
> 
> Same here.

Well, technically okay, but it means more cleanup will then need doing after
your change, by someone else.

Jan


More information about the Binutils mailing list