[PATCH v6 4/4] aarch64: Emit pdata/xdata SEH records from md_finish
Evgeny Karpov
evgeny.karpov@arm.com
Wed Mar 18 17:06:16 GMT 2026
On Fri, Mar 13, 2026, Alice Carlotti wrote:
> It looks like you now call obj_coff_generate_pdata twice - once in
> write_object_file and once in aarch64_md_finish? That seems unintuitive,
> although I see that
>
> + if (!seh_ctx_root)
> + return;
> +
> + struct seh_aarch64_context *seh_ctx = seh_ctx_root;
> + seh_ctx_root = NULL;
>
> makes the second call effectively a nop - this definitely justifies a comment
> to explain what's going on. However, it feels like there should be a better
> way of doing this - e.g. by making early generation a separate hook.
It will be moved to a separate function.
> Also, should this be part of patch 3/4? It doesn't seem to make sense as a
> standalone change.
It seems reasonable to separate them, however OK, it will be merged with 3/4.
Regards,
Evgeny
More information about the Binutils
mailing list