[RFC PATCH v2 1/4] RX: bfd rx-linux FDPIC support

yoshinori.sato@nifty.com yoshinori.sato@nifty.com
Wed Mar 18 12:54:45 GMT 2026


On Mon, 16 Mar 2026 19:11:13 +0900,
Oleg Endo wrote:
> 
> Hi,
> 
> Since I'm an active RX user myself, I got curious and only briefly looked
> through it, spotted one thing, see below.
> 
> On Mon, 2026-03-16 at 18:31 +0900, Yoshinori Sato wrote:
> 
> > +  bool fdpic_p;
> > +};
> > +
> > +/* Get the sh ELF linker hash table from a link_info structure.  */
> > +
> > +#define rx_elf_hash_table(p) \
> > +  ((is_elf_hash_table ((p)->hash)					\
> > +    && elf_hash_table_id (elf_hash_table (p)) == RX_ELF_DATA)		\
> > +   ? (struct elf_rx_link_hash_table *) (p)->hash : NULL)
> > +#define MINUS_ONE ((bfd_vma) 0 - 1)
> 
> The comment above says "Get the sh ELF...".
> I guess it should say "Get the RX ELF ..."

Thanks. I'll fix and sent v3.

> Best regards,
> Oleg Endo
> 

-- 
Yosinori Sato


More information about the Binutils mailing list