[PATCH 1/1] s390: Un-XFAIL some non-PIC load offset ELF visibility tests

[Jens Remus]

On 3/14/2026 1:01 AM, Alan Modra wrote:
> On Fri, Mar 13, 2026 at 04:11:19PM +0100, Jens Remus wrote:
>> In general creating shared libraries from non-PIC compiled code is not
>> supported on s390 64-bit (s390x).
> 
> Then don't run what are senseless tests for s390.  It really isn't
> worth wasting time trying to make these tests work.  Even x86 (which
> is where this non-pic shared library nonsense originated) xfails a
> bunch of the non-pic shared tests.

I simply did not dare.  Given many targets run those tests I felt like
there must be a hidden sense that I just did not realize yet.

Thanks for your feedback!  I'll send a v2 that skips the non-PIC shared
library visibility tests on s390 64-bit (s390x).

> In my opinion they all ought to be removed unless they use assembly
> source files, because there is a fundamental gcc conflation of two
> separate concepts: "compile for a shared library" and "compile
> non-pic".  Yes, non-pic shared libraries can be supported via dynamic
> text relocations if you control your gag reflex, but you surely want
> "compile for a shared library" in shared library tests.  Thus the
> compiled non-pic shared library ld tests are all invalid.

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
jremus@de.ibm.com / jremus@linux.ibm.com

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Ehningen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/