[PATCH v5 0/5] Implement Structured Exception Handling (SEH) on AArch64
Evgeny Karpov
evgeny.karpov@arm.com
Mon Mar 9 14:45:53 GMT 2026
On Fri, Mar 06, 2026, Alan Modra wrote:
> This looks OK, except for the frag_offset_ignore_align_p changes and
> use of that function. Patch 4/5 should be dropped from the series
> since there is no need to search the reversed frag order in the other
> use of the function. You also shouldn't need that change if you pass
> the start and end frags in the correct order in patch 3/5. Also, you
> need to check the return of frag_offset_ignore_align_p. If the
> function returns false, "offset" will be uninitialised.
It looks like frag_offset_ignore_align_p does not cover all cases and cannot
be used for reliable calculation. Patch 4/5 will be dropped, and the calculation
of function size will be replaced with an implementation that covers all cases
with alignment.
Regards,
Evgeny
More information about the Binutils
mailing list