[PATCH v3] RISC-V: Fix build with GCC-8

Maciej W. Rozycki macro@orcam.me.uk
Fri Jun 26 11:02:42 GMT 2026


On Fri, 26 Jun 2026, Jan Beulich wrote:

> >  I think it would be more useful to the reader if the commit referred to 
> > the relevant C language standard and minimum compiler version as given by 
> > Andreas: <https://inbox.sourceware.org/binutils/mvmtsqtzgve.fsf@suse.de/>.
> 
> To be honest, I think relatively basic standard C aspects should be known
> to people, and "rejects a declaration right after a case label" is enough
> of a pointer imo.

 I don't expect everyone to track or remember all the individual features 
as they are added to standard revisions or compiler implementations, and 
details provided by Andreas are useful in determining the prerequsites.

 Indeed the breakage caused in the first place serves as a proof: you'd 
imply the code writer as well the approver should have known this feature 
isn't there in every compiler version supported for building binutils, and 
yet they missed it.

 Why do you think it would be preferable to require everyone to chase 
every time something that has been already determined?

> >  FWIW it broke the build with GCC 10.2.1 here (production box, system
> > compiler).
> 
> At the risk of coming across blunt, but: You complain about too little
> detail above, and then you report this issue without providing any detail?

 Why would I need to repeat the same exact details as with the original 
report?  This is just to confirm that the same issue triggers for versions 
other than 8.5.0 (just as Andreas has indicated).  I reckon Andrew Burgess 
also reported breakage with his environment.

  Maciej


More information about the Binutils mailing list