[PATCH v7 3/3] aarch64: Implement Structured Exception Handling (SEH) on AArch64

[Evgeny Karpov]

On Thu, 26 Mar 2026, Saurabh Jha wrote:
> > +
> > +      seh_ctx_cur->handler.X_op = O_constant;
> > +      seh_ctx_cur->handler.X_add_number = 0;
> > +
> > +      if (strcasecmp (symbol_name, "@0") == 0
> > +	  || strcasecmp (symbol_name, "@null") == 0)
> > +	;
>
> If we're not doing anything in this if body, why do we have it? Is it to be
> able to write the bottom conditionals in an easier way?yhn

It makes sense to change. The condition will be rewritten.

> > +  return true;
> > +}
> > +
> > +/* Write out the xdata information for one function.  */
> > +static void
> > +seh_aarch64_write_function_xdata (struct seh_aarch64_context *seh_ctx)
> > +{
> 
> Is there a way to break down this function? Perhaps around your conditionals
> inside the while (true) loop?

xdata record writing will be moved to a separate function.

> > +   pdata record is not implemented yet.  */
> > +
> > +#ifndef OBJ_COFF_SEH_AARCH64_H
> > +#define OBJ_COFF_SEH_AARCH64_H
> > +
> > +typedef enum seh_aarch64_unwind_types
> > +{
> 
> Can you add a link to the documentation of the unwind types?

The link to the documentation will be added.

Regards,
Evgeny