object attributes v2 test woes

Alan Modra amodra@gmail.com
Sat Jan 24 03:25:28 GMT 2026


On Fri, Jan 23, 2026 at 10:43:15AM +0000, Matthieu Longo wrote:
> On 23/01/2026 04:01, Alan Modra wrote:
> > Tested at commit 25bb742bc1
> > 
> > csky-linux-gnu breaks all over the place with
> > assertion fail bfd/elf-attrs.c:2515
> > 
> > Then there are these testsuite failures.
> > arm-vxworks  +FAIL: GNU attributes v1/v2: no support for directive .gnu_attribute
> > mips-vxworks  +FAIL: GNU attributes v1/v2: no support for directive .gnu_attribute
> > powerpc-wrs-vxworks  +FAIL: GNU attributes v1/v2: no support for directive .gnu_attribute
> > sparc-vxworks  +FAIL: GNU attributes v1/v2: no support for directive .gnu_attribute
> > 
> > I'm sure the guilty parties know who they are. ;-)  Please fix.
> > 
> 
> Hi Alan,
> 
> I will have a look at those asap.

Never mind, I've fixed them.

Add vxworks and windiss to supported targets.  is_elf_target excludes
them as a hack to work around multiple other elf test failures.

On these targets, fixes
FAIL: GNU attributes v1/v2: no support for directive .gnu_attribute

diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 03306c112f5..72cbf4a4e05 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -509,7 +509,8 @@ proc gas_sframe_check {} {
 
 # Whether a target supports Object Attributes v1
 proc supports_oa_v1 {} {
-    if { ! [is_elf_format] } {
+    if { ![is_elf_format]
+	 && ![istarget *-*-vxworks*] && ![istarget *-*-windiss*] } {
 	return 0
     }
     if { [istarget arc-*-*]
@@ -531,7 +532,8 @@ proc supports_oa_v1 {} {
 
 # Whether a target supports Object Attributes v2
 proc supports_oa_v2 {} {
-    if { ! [is_elf_format] } {
+    if { ![is_elf_format]
+	 && ![istarget *-*-vxworks*] && ![istarget *-*-windiss*] } {
 	return 0
     }
     if { [istarget aarch64*-*-*] } {

-- 
Alan Modra


More information about the Binutils mailing list