[PATCH v2] fix build failures due to incorrect format specifier for uint64_t

Matthieu Longo matthieu.longo@arm.com
Fri Jan 23 10:57:28 GMT 2026


On 23/01/2026 09:00, Jan Beulich wrote:
> On 22.01.2026 18:57, Matthieu Longo wrote:
>> --- a/bfd/elf-attrs.c
>> +++ b/bfd/elf-attrs.c
>> @@ -2743,7 +2743,7 @@ oav2_parse_subsection (bfd *abfd,
>>         goto error;
>>       }
>>   
>> -  const uint32_t subsection_len = bfd_get_32 (abfd, cursor);
>> +  const unsigned int subsection_len = bfd_get_32 (abfd, cursor);
>>     const bfd_byte *const end = cursor + subsection_len;
>>     total_read += F_SUBSECTION_LEN;
>>     cursor += F_SUBSECTION_LEN;
> 
> This is okay, but ...
> 
>> @@ -2756,8 +2756,9 @@ oav2_parse_subsection (bfd *abfd,
>>       }
>>     else if (subsection_len < F_MIN_SUBSECTION_DATA_LEN)
>>       {
>> -      _bfd_error_handler (_("%pB: error: subsection length of %u is too small"),
>> -			  abfd, subsection_len);
>> +      _bfd_error_handler
>> +	(_("%pB: error: subsection length of %u is too small"),
>> +	 abfd, subsection_len);
>>         goto error;
>>       }
> 
> ... why's this hunk needed?
> 

I originally fixed the %u because subsection_len wsa uint32_t, and made the arguments aligned as in the previous _bfd_error_handler l. 2753.

I removed it.

>> --- a/bfd/elfxx-aarch64.c
>> +++ b/bfd/elfxx-aarch64.c
>> @@ -1100,8 +1100,8 @@ _bfd_aarch64_oav2_attr_merge (const struct bfd_link_info *info,
>>         if (attr_info == NULL)
>>   	{
>>   	  info->callbacks->einfo
>> -	    (_("%pB: warning: cannot merge unknown tag 'Tag_unknown_%u' "
>> -	       "(=0x%x) in subsection '%s'.\n"),
>> +	    (_("%pB: warning: cannot merge unknown tag 'Tag_unknown_%" PRIu64 "'"
>> +	       " (=0x%" PRIx32 ") in subsection '%s'.\n"),
> 
> Please can the full stop then also be got rid of at this occasion?
> 

Fixed.

> Okay with respective adjustments.
> 
> Jan

Matthieu


More information about the Binutils mailing list