[PATCH 4/5] libsframe: rename flip_fre_stack_offsets to flip_fre_datawords

Jens Remus jremus@linux.ibm.com
Thu Jan 22 12:46:42 GMT 2026


On 1/22/2026 12:34 PM, Alan Modra wrote:
> On Thu, Jan 22, 2026 at 11:41:09AM +0100, Jens Remus wrote:
>> On 1/20/2026 11:28 AM, Indu Bhagat wrote:
>>> Also adjust function level comment for flip_fre_datawords.
>>>
>>> libsframe/
>>> 	* sframe.c (flip_fre_stack_offsets): Rename to
>>> 	flip_fre_datawords.
>>> ---
>>>  libsframe/sframe.c | 19 ++++++++++---------
>>>  1 file changed, 10 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/libsframe/sframe.c b/libsframe/sframe.c
>>> index 38baa2277c1..9240a65b47f 100644
>>> --- a/libsframe/sframe.c
>>> +++ b/libsframe/sframe.c
>>> @@ -402,20 +402,20 @@ flip_fre_start_address (void *addr, uint32_t fre_type)
>>>  }
>>>  
>>>  static void
>>> -flip_fre_stack_offsets (char *offsets, uint8_t offset_size, uint8_t offset_cnt)
>>> +flip_fre_datawords (char *datawords, uint8_t dataword_size, uint8_t dataword_cnt)
>>>  {
>>>    int j;
>>>  
>>> -  if (offset_size == SFRAME_FRE_OFFSET_2B)
>>> +  if (dataword_size == SFRAME_FRE_DATAWORD_2B)
>>>      {
>>> -      uint16_t *ust = (uint16_t *)offsets;
>>> -      for (j = offset_cnt; j > 0; ust++, j--)
>>> +      uint16_t *ust = (uint16_t *)datawords;
>>> +      for (j = dataword_cnt; j > 0; ust++, j--)
>>
>> Unrelated: What does "ust" refer to?  "unsigned type"?
> 
> "unsigned short thing" maybe :-)  Commit efcfd085473e changes all
> this anyway, and the "char *offsets" to "void *offsets" so fewer casts
> are needed.

Alan, thanks for enlightening me! :-)  Makes sense.  Then "uit"
likely stands for "unsigned integer thing".

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
jremus@de.ibm.com / jremus@linux.ibm.com

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Ehningen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/



More information about the Binutils mailing list