[PATCH 1/2] sframe: Use UNRESOLVED instead of FAIL

[Claudiu Zissulescu]

>> +    global runtests
>> +
> 
> runtests unused?

Removed.

> 
>> +    set binary $READELF
>> +    set progopts "-j .rela.sframe"
>> +
>> +    # Ensure consistent sorting of symbols
>> +    if {[info exists env(LC_ALL)]} {
>> +    set old_lc_all $env(LC_ALL)
>> +    }
>> +    set env(LC_ALL) "C"
> 
> Is this environment var LC_ALL setting and unsetting needed here?
> 
> The sframe.exp file already does it, before running any test, and resets 
> after.
> 
>> +    set cmd "$binary $progopts $binfile > dump.out"
>> +    send_log "$cmd\n"
>> +    catch "exec $cmd" comp_output
>> +    if {[info exists old_lc_all]} {
>> +    set env(LC_ALL) $old_lc_all
>> +    } else {
>> +    unset env(LC_ALL)
>> +    }
> 
> Same for this.


Fixed.

> 
>> +    set comp_output [prune_warnings $comp_output]
>> +    if ![string match "" $comp_output] then {
>> +    send_log "$comp_output\n"
>> +    return 1
>> +    }
>> +
>> +    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
>> +    verbose -log "output is [file_contents "dump.out"]" 2
>> +    return 1
>> +    }
>> +    return 0
>> +}
>> +
>>   proc check_pr33401 { } {
>>       global CXX_FOR_TARGET
>>       global ld
>>       global srcdir
>>       global subdir
>> +    global as
>> +    global LDFLAGS
>> +    global env
>> +
>> +    set objfiles {}
>> +    set testname "PR ld/33401"
>> +    set failed 0
>> +    set linkfile "tmpdir/pr33401.o"
>> +    set src_files [list "StateClient.cpp" "StatePlaying.cpp"]
>> +
>> +    # Check to see if the C and C++ compilers work
>> +    if { ![check_compiler_available] || [which $CXX_FOR_TARGET] == 0 } {
>> +    unsupported $testname
>> +    return
>> +    }
>> +
> 
> Sorry I am just noticing this.  Now that we dont invoke 
> run_cc_link_tests, is check_compiler_available still needed ?

Yes, for ld_compile :)

> 
> LGTM, otherwise.

I have pushed the modified patch as indicated.

Thank you,
Claudiu