[PATCH 1/1] sframe: Use UNRESOLVED instead of FAIL

Indu Bhagat indu.bhagat@oracle.com
Wed Jan 21 06:38:40 GMT 2026


On 1/20/26 4:47 AM, Claudiu Zissulescu wrote:
>>
>> It was added by the following commit to address the case when user 
>> cflags include -fno-inline, affected the coverage of this test.
>>
>> commit ba038bba603d18b431ad1b69505553881b8a39c7
>> Author: Alan Modra <amodra@gmail.com>
>> Date:   Sat Dec 13 09:30:46 2025 +1030
>>
>>      Re: ld: testsuite: Add sframe test for PR 33401
>>
>>      If user CXXFLAGS include -fno-inline the test fails with
>>      FAIL: PR ld/33401 (Step 1: Create relocatable object and check 
>> R_*_NONE)
>>      This should not be a FAIL.  If the compiler does not generate 
>> R_*_NONE
>>      (a good thing!) then it should be UNTESTED, which means the readelf
>>      check can't be done by run_cc_link_tests.  I haven't made that 
>> change
>>      in this patch, just worked around a user -fno-inline.
> 
> Now, if user is adding -fno-inline, the test will return UNTESTED as 
> Alan indicated.

OK.  My judgement was that keeping -finline will only increase the 
coverage of the test (more instances with R_*_NONE are generated).  And 
that what we are testing to ensure no regressions..


More information about the Binutils mailing list