[PATCH v2] opcodes: Fix BMASKI disassembly for immediate 32 on M*Core

[Jan Beulich]

On 20.01.2026 14:55, Michal Sobon wrote:
> --- a/gas/testsuite/gas/mcore/allinsn.d
> +++ b/gas/testsuite/gas/mcore/allinsn.d
> @@ -394,5 +394,7 @@ Disassembly of section \.text:
>  
>  0+0106 <zexth>:
>   106:	0164      	zexth	r4
> - 108:	0f00      	cmpne	r0, r0
> +
> +0+0108 <Bmaski>:
> + 108:	2c04      	bmaski	r4, 32
>   10a:	0f00      	cmpne	r0, r0

As can be seen from the addresses here, ...

> --- a/gas/testsuite/gas/mcore/allinsn.s
> +++ b/gas/testsuite/gas/mcore/allinsn.s
> @@ -141,6 +141,6 @@ foolit:
>  	test xtrb3  "r1, r13"
>  	test zextb  r8
>  	test zexth  r4
> -	clrc			// These two instructions pad the object file
> -	clrc			// out to a 16 byte boundary.
> +	test Bmaski "r4, 32"
> +	clrc			// This instruction pads the object file out to a 16 byte boundary.

... the comment was wrong and is again wrong (.text ends at 0x10c, not
e.g. 0x110). I disagree making adjustments like this. Plus you introduce
too long a line this way.

I see two options: Either you insert ahead of the first clrc and leave
the rest alone. Or you drop the part that's wrong entirely, then also
taking care of ...

>  	
> \ No newline at end of file

... this at the same time.

Jan