[PATCH v12 02/25] Object Attributes v2: new abstractions for subsections and attributes

[Jan Beulich]

On 16.01.2026 19:59, Matthieu Longo wrote:
> @@ -3160,6 +3185,40 @@ extern Elf_Internal_Shdr *_bfd_elf_single_rel_hdr
>  extern bool _bfd_elf_read_notes
>    (bfd *, file_ptr, bfd_size_type, size_t) ATTRIBUTE_HIDDEN;
>  
> +extern obj_attr_v2_t *bfd_elf_obj_attr_v2_init (obj_attr_tag_t,
> +  union obj_attr_value_v2) ATTRIBUTE_HIDDEN;
> +extern void _bfd_elf_obj_attr_v2_free (obj_attr_v2_t *, obj_attr_encoding_v2_t)
> +  ATTRIBUTE_HIDDEN;
> +extern obj_attr_v2_t *_bfd_elf_obj_attr_v2_copy (const obj_attr_v2_t *,
> +  obj_attr_encoding_v2_t) ATTRIBUTE_HIDDEN;
> +extern int _bfd_elf_obj_attr_v2_cmp (const obj_attr_v2_t *,
> +  const obj_attr_v2_t *) ATTRIBUTE_HIDDEN;
> +extern obj_attr_v2_t *

Would be nice if style was consistent at least within a patch. Here: Everywhere
else the return type doesn't live alone on a line.

> +obj_attr_v2_find_by_tag (const obj_attr_subsection_v2_t *, obj_attr_tag_t,
> +  bool) ATTRIBUTE_HIDDEN;
> +LINKED_LIST_MUTATIVE_OPS_PROTOTYPE (obj_attr_subsection_v2_t,
> +				    obj_attr_v2_t, ATTRIBUTE_HIDDEN);
> +LINKED_LIST_MERGE_SORT_PROTOTYPE_ (obj_attr_v2_t, ATTRIBUTE_HIDDEN);
> +LINKED_LIST_MERGE_SORT_PROTOTYPE (obj_attr_subsection_v2_t,
> +				  obj_attr_v2_t, ATTRIBUTE_HIDDEN);
> +extern obj_attr_subsection_v2_t *bfd_elf_obj_attr_subsection_v2_init
> +  (const char *, obj_attr_subsection_scope_v2_t, bool, obj_attr_encoding_v2_t);
> +extern void _bfd_elf_obj_attr_subsection_v2_free (obj_attr_subsection_v2_t *)
> +  ATTRIBUTE_HIDDEN;
> +extern obj_attr_subsection_v2_t *_bfd_elf_obj_attr_subsection_v2_copy
> +  (const obj_attr_subsection_v2_t *) ATTRIBUTE_HIDDEN;
> +extern int _bfd_elf_obj_attr_subsection_v2_cmp
> +  (const obj_attr_subsection_v2_t *, const obj_attr_subsection_v2_t *)
> +  ATTRIBUTE_HIDDEN;
> +extern obj_attr_subsection_v2_t * obj_attr_subsection_v2_find_by_name
> +  (obj_attr_subsection_v2_t *, const char *, bool);

Still a missing ATTRIBUTE_HIDDEN? Or not quite suitable name for an export?

Also there's still a stray blank after the return type's *.

As before - okay with the small issues fully addressed (and assuming you've
got an Arm64-side okay already).

Jan