[COMMITTED] gas: sframe: do not test whether offsetT exceeds INT64_MIN..INT64_MAX

[Jens Remus]

Hello Jan!

On 1/13/2026 2:59 PM, Jan Beulich wrote:
> On 13.01.2026 14:24, Jens Remus wrote:
>> A value of type offsetT, which is either a signed 32-bit or 64-bit
>> integer, cannot exceed the range of INT64_MIN..INT64_MAX.  This
>> resolves the following compile error:
>>
>> ../../binutils-gdb/gas/gen-sframe.c: In function ‘get_offset_size_in_bytes’:
>> ../../binutils-gdb/gas/gen-sframe.c:213:45: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>>   213 |   else if ((sizeof (offsetT) > 4) && (value <= INT64_MAX && value >= INT64_MIN))
>>       |                                             ^~
>> ../../binutils-gdb/gas/gen-sframe.c:213:67: error: comparison is always true due to limited range of data type [-Werror=type-limits]
>>   213 |   else if ((sizeof (offsetT) > 4) && (value <= INT64_MAX && value >= INT64_MIN))
> 
> This same error ...
> 
>> --- a/gas/gen-sframe.c
>> +++ b/gas/gen-sframe.c
>> @@ -210,7 +210,7 @@ get_offset_size_in_bytes (offsetT value)
>>      size = 2;
>>    else if (value <= INT32_MAX && value >= INT32_MIN)
> 
> ... will trigger here on a !BFD64 build.

Argh!  Good catch! Thanks for letting me know!  How do I resolve this
properly?  Shall I commit another fix "gas: sframe: do not test whether
32-bit offsetT exceeds INT32_MIN..INT32_MAX" or shall I better revert
both commits and start fresh with a v3 review of the initial patch?

I propose the following as solution:

  if (value <= INT8_MAX && value >= INT8_MIN)
    size = 1;
  else if (value <= INT16_MAX && value >= INT16_MIN)
    size = 2;
  else if ((sizeof (offsetT) == 4) || (value <= INT32_MAX && value >= INT32_MIN))
    size = 4;
  else if (sizeof (offsetT) == 8)
    size = 8;

> 
>>      size = 4;
>> -  else if ((sizeof (offsetT) > 4) && (value <= INT64_MAX && value >= INT64_MIN))
>> +  else if (sizeof (offsetT) > 4)
>>      size = 8;
>>  
>>    return size;
Thanks and regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
jremus@de.ibm.com / jremus@linux.ibm.com

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Ehningen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/