[PATCH] libiberty/testsuite: make test-pexecute's -t option a little more useful

[Andrew Pinski]

On Tue, Nov 18, 2025 at 7:22 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Printing the program name twice doesn't really provide much value.
> ---
> The reason I looked here in the first place is the log spam this test
> causes: Per run I'm getting one instance of
>
> systemd-coredump[18150]: Core Dumping has been disabled for process 18149 (test-pexecute).
> systemd-coredump[18150]: Process 18149 (test-pexecute) of user 1000 dumped core.
>
> or alike. Imo testsuite runs shouldn't have such effects, unless of course
> they actually surface problems. I assume it's the "abort" test which
> causes this behavior, and it would be nice to somehow silence that.
>
> --- a/libiberty/testsuite/test-pexecute.c
> +++ b/libiberty/testsuite/test-pexecute.c
> @@ -211,7 +211,7 @@ main (int argc, char **argv)
>        const char *pex_run_err;                                         \
>        if (trace)                                                       \
>         fprintf (stderr, "Line %d: running %s %s\n",                    \
> -                __LINE__, EXECUTABLE, ARGV[0]);                        \
> +                __LINE__, EXECUTABLE, ARGV[1]);                        \
>        pex_run_err = pex_run (PEXOBJ, FLAGS, EXECUTABLE, ARGV, OUTNAME, \
>                              ERRNAME, &err);                            \
>        if (pex_run_err != NULL)                                         \


This is ok with an added changelog entry to the commit message.
I was originally cautious about ARGV[1] being NULL but I checked and
this is not called any time it is null.

Thanks,
Andrew