[PATCH v11 02/25] Object Attributes v2: new abstractions for subsections and attributes

[Jan Beulich]

On 31.12.2025 00:05, Matthieu Longo wrote:
> --- a/bfd/elfxx-aarch64.h
> +++ b/bfd/elfxx-aarch64.h
> @@ -236,6 +236,12 @@ _bfd_aarch64_elf_write_core_note (bfd *, char *, int *, int, ...)
>  #define elf_backend_grok_psinfo		_bfd_aarch64_elf_grok_psinfo
>  #define elf_backend_write_core_note	_bfd_aarch64_elf_write_core_note
>  
> +extern obj_attr_version_t
> +_bfd_aarch64_obj_attrs_version_dec (uint8_t);
> +
> +extern uint8_t
> +_bfd_aarch64_obj_attrs_version_enc (obj_attr_version_t);

Please may I remind you to extend comments given to the entire patch / series,
where applicable? By their names these are again libbfd-internal, yet they
lack ATTRIBUTE_HIDDEN. Despite ...

>  extern bfd *
>  _bfd_aarch64_elf_link_setup_gnu_properties (struct bfd_link_info *)
>    ATTRIBUTE_HIDDEN;

... the attribute even being present in context.

Jan