[PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors

Alan Modra amodra@gmail.com
Tue Feb 24 01:14:53 GMT 2026


On Mon, Feb 23, 2026 at 03:27:38PM +0100, Jan Beulich wrote:
> On 23.02.2026 14:26, simon.marchi@polymtl.ca wrote:
> > From: Simon Marchi <simon.marchi@polymtl.ca>
> > --- a/opcodes/riscv-dis.c
> > +++ b/opcodes/riscv-dis.c
> > @@ -110,7 +110,7 @@ parse_riscv_dis_option_without_args (const char *option,
> >  /* Parse RISC-V disassembler option (possibly with arguments).  */
> >  
> >  static void
> > -parse_riscv_dis_option (const char *option, struct disassemble_info *info)
> > +parse_riscv_dis_option (char *option, struct disassemble_info *info)
> >  {
> >    char *equal, *value;
> >  
> ... this change, while apparently correct, isn't very nice.

I think it both correct and nice.  Nice because it removes the lie
that the "option" string is not changed by the function.

-- 
Alan Modra


More information about the Binutils mailing list