Expected pr24576-1 and pr24576-2 failures on Windows/MinGW
Alan Modra
amodra@gmail.com
Mon Feb 23 10:10:24 GMT 2026
On Mon, Feb 23, 2026 at 08:29:54AM +0100, Jan Beulich wrote:
> Since it's run_dump_test, you'd add suitable #xfail lines close to the top
> of the *.d files (see binutils/testsuite/lib/binutils-common.exp, which
xfail is for target. Here we apparently need to do something special
for certain hosts.
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=msvc-170
says st_ino has no meaning on FAT, HPFS, or NTFS windows file systems
The simplest thing to do is ignore this and tell people to put up with
some FAILs. ;-) Apart from that, not running the test on hosts
likely to have non-unix file systems sounds like a reasonable plan.
BTW, I think our include/same-inode.h is broken since it uses a gnulib
macro _GL_WINDOWS_STAT_INODES.
> > --- a/ld/testsuite/ld-scripts/script.exp
> > +++ b/ld/testsuite/ld-scripts/script.exp
> > @@ -233,8 +233,20 @@ run_dump_test "pr20302"
> > run_dump_test "output-section-types"
> > run_dump_test "ld-version"
> > run_dump_test "ld-version-2"
> > -run_dump_test "pr24576-1"
> > -run_dump_test "pr24576-2"
> > +
> > +# On Windows hosts the following two cases are expected to fail because
> > +# SAME_INODE macro called from ldfile_find_command_file() in ld/ldfile.c
> > +# always returns 0 and it is unknown if the macro will be fixed, if ever.
> > +# So instead of calling run_dump_test we just call dummy xfail to notify
> > +# users that there is a problem.
> > +if ![string match "*-mingw*" $host_triplet] {
> > + run_dump_test "pr24576-1"
> > + run_dump_test "pr24576-2"
> > +} else {
> > + xfail "pr24576-1"
> > + xfail "pr24576-2"
> > +}
> > +
> > run_dump_test "linker-script-not-found"
> >
> > run_dump_test "segment-start" {{name (default)}}
> >
> >
> > Patches and ideas are welcome,
> > Jan
> >
--
Alan Modra
More information about the Binutils
mailing list