[PATCH] objdump: sframe: fix multiple emission of SFrame and DWARF Frame

[Jan Beulich]

On 05.02.2026 10:02, Indu Bhagat wrote:
> On 2/3/26 11:07 PM, Jan Beulich wrote:
>> On 03.02.2026 23:37, Indu Bhagat via Binutils wrote:
>>> --- /dev/null
>>> +++ b/binutils/testsuite/binutils-all/x86-64/objdump-sframe-2.d
>>> @@ -0,0 +1,33 @@
>>> +#name: objdump sframe with eh_frame
>>> +#source: sframe-func.s
>>> +#as: --gsframe
>>> +#objdump: --sframe -WF
>>> +#target: x86_64-*-*
>>> +#xfail: ![gas_sframe_check]
>>
>> Why xfail? A target not supporting SFrame will never pass this test. It thus
>> shouldn't be a valid target for this test in the first place.
> 
> SFrame is not supported for x32.  gas_sframe_check will fail for x32, 
> and the test is reported as XFAIL.  May be its better to use '#notarget: 
> x86_64-*-gnux32' instead of '#xfail: ![gas_sframe_check]' ?

Yes, #notarget is what I think wants using. I'm unconvinced of using
x86_64-*-gnux32 there, though. I'd expect ![gas_sframe_check] to be more
appropriate.

Jan