[PATCH v4 3/7] Adjust x64 SEH implementation for AArch64
Jan Beulich
jbeulich@suse.com
Mon Feb 2 09:01:39 GMT 2026
On 02.02.2026 09:39, Evgeny Karpov wrote:
> On Mon, Feb 02, 2026, Jan Beulich wrote:
>>>>> @@ -366,10 +450,21 @@ obj_coff_seh_handler (int what ATTRIBUTE_UNUSED)
>>>>> seh_ctx_cur->handler_data.X_add_number = 0;
>>>>> seh_ctx_cur->handler_flags = 0;
>>>>>
>>>>> +#if defined (COFFAARCH64)
>>>>> + seh_ctx_cur->aarch64_ctx.xdata_header.x = 1;
>>>>
>>>> Why unconditionally 1?
>>>
>>> It indicates the presence of exception data, which is always emitted.
>>
>> Why's there a flag if this data is always emitted?
>
> xdata might not have exception data as an option, however in the current
> aarch64 implementation it is always emitted.
In which case please add a (brief) comment here saying so.
Jan
More information about the Binutils
mailing list