[COMMITTED, PATCH] ld: Replace "{dummy.s}" with "[list $dummy_s]"
H.J. Lu
hjl.tools@gmail.com
Fri Aug 28 20:42:33 GMT 2026
On Fri, Aug 28, 2026 at 8:29 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Fri, Aug 28, 2026 at 04:24:48PM +0800, H.J. Lu wrote:
> > I am checking this patch after testing with x86_64-w64-mingw32.
>
> Fails remain.
>
> +FAIL: ld-plugin/lto-3r
> +FAIL: ld-plugin/lto-4r-a
> +FAIL: ld-plugin/lto-4r-b
> +FAIL: ld-plugin/lto-4r-c
> +FAIL: ld-plugin/lto-4r-d
> +FAIL: ld-plugin/lto-5r
> +FAIL: ld-plugin/lto-10r
> +FAIL: PR ld/19317 (2)
> +FAIL: LTO 3b
> +FAIL: PR ld/19317 (3)
>
> ld-plugin/dummy.s: Assembler messages:
> ld-plugin/dummy.s:1: Error: junk at end of line, first unrecognized character is `-
> '
>
> The above also caused a bunch of tests to not be run.
>
> --
> Alan Modra
I am checking in this patch.
--
H.J.
---
commit d658ddcc389085970ac025414cae7ad908f40726
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Fri Aug 28 09:08:39 2026 +0800
lto: Don't check format of IR dummy file
added
.section .note.GNU-stack,"",%progbits
to testsuite/ld-plugin/dummy.s for PR ld/34572 tests with Clang. But
it doesn't work for non-ELF targets. Add dummy-elf.s and restore the
previous dummy.s. Define dummy_s to dummy-elf.s for ELF targets and to
dummy.s for non-ELF targets. Replace "{dummy.s}" with "[list $dummy_s]".
Also build pr28264.so only for ELF targets since it uses readelf.
PR ld/28264
PR ld/34572
* testsuite/ld-plugin/dummy-elf.s: New file.
* testsuite/ld-plugin/dummy.s: Revert commit d658ddcc389.
* testsuite/ld-plugin/lto.exp (dummy_s): New.
Build pr28264.so only for ELF targets.
Replace "{dummy.s}" with "[list $dummy_s]".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ld-Replace-dummy.s-with-list-dummy_s.patch
Type: text/x-patch
Size: 4090 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20260829/0bd3f923/attachment.bin>
More information about the Binutils
mailing list