[PATCH 07/13] gdb/csky: remove uses of sprintf

[Simon Marchi]

When building on macOS, I get a few:

    /Users/smarchi/src/binutils-gdb/gdb/csky-tdep.c:434:4: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
      434 |           sprintf (tdesc_reg.name, "cp1cr%d", remain);
          |           ^

Replace these uses with snprintf, via xsnprintf, which asserts that the
destination buffer was large enough for the output string.

Change-Id: Idc5c0c42479f767c63b0d0cece5ab14cacec9a60
---
 gdb/csky-tdep.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
index e86f79a42eaf..ad0d50d8218d 100644
--- a/gdb/csky-tdep.c
+++ b/gdb/csky-tdep.c
@@ -431,19 +431,22 @@ csky_get_supported_register_by_index (int index)
     {
       case 0: /* Bank1.  */
 	{
-	  sprintf (tdesc_reg.name, "cp1cr%d", remain);
+	  xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp1cr%d",
+		     remain);
 	  tdesc_reg.num = 189 + remain;
 	}
 	break;
       case 1: /* Bank2.  */
 	{
-	  sprintf (tdesc_reg.name, "cp2cr%d", remain);
+	  xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp2cr%d",
+		     remain);
 	  tdesc_reg.num = 276 + remain;
 	}
 	break;
       case 2: /* Bank3.  */
 	{
-	  sprintf (tdesc_reg.name, "cp3cr%d", remain);
+	  xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp3cr%d",
+		     remain);
 	  tdesc_reg.num = 221 + remain;
 	}
 	break;
@@ -460,7 +463,8 @@ csky_get_supported_register_by_index (int index)
       case 13: /* Bank14.  */
 	{
 	  /* Regitsers in Bank4~14 have continuous regno with start 308.  */
-	  sprintf (tdesc_reg.name, "cp%dcr%d", (multi + 1), remain);
+	  xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp%dcr%d",
+		     (multi + 1), remain);
 	  tdesc_reg.num = 308 + ((multi - 3) * 32) + remain;
 	}
 	break;
@@ -482,7 +486,8 @@ csky_get_supported_register_by_index (int index)
       case 29: /* Bank31.  */
 	{
 	  /* Regitsers in Bank16~31 have continuous regno with start 660.  */
-	  sprintf (tdesc_reg.name, "cp%dcr%d", (multi + 2), remain);
+	  xsnprintf (tdesc_reg.name, sizeof (tdesc_reg.name), "cp%dcr%d",
+		     (multi + 2), remain);
 	  tdesc_reg.num = 660 + ((multi - 14) * 32) + remain;
 	}
 	break;
-- 
2.55.0