[to-be-committed v2] PR ld/24600: BFD: Fix use-after-free from `_bfd_load_armap'
Maciej W. Rozycki
macro@orcam.me.uk
Mon Aug 17 14:22:47 GMT 2026
On Mon, 17 Aug 2026, Alan Modra wrote:
> > I was happy with v1, but this is good too.
>
> I'm going to commit this revision instead. I'd started looking at
> removing the struct orl name indirection before you posted your v1
> patch. When I saw that patch appear I decided to leave it to you, but
> then had some spare time and finished the struct orl change.
FWIW, again I think that code cleanups should be separate from bug fixes,
so as to make the changes easier for people to digest, perhaps many years
later. So I'd rather the `struct orl' name indirection removal was made
with a preparatory change. I did not consider such an update, I have to
admit; I did not analyse whether there was any real justification for the
indirection to be there in the first place.
Since you have already pushed your fix as a combined change, it has been
cast in the repo and I think it may not be terribly productive to go back
and revert the fix, split it into two patches, and reapply them in that
form. So I can only thank you for your extra effort.
Maciej
More information about the Binutils
mailing list