[PATCH] binutils/readelf: Remove unused static variables

[Filipovic, Bratislav]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Jan,

Can you push this since I don't have write-after-approval yet?

Regards Bratislav

-----Original Message-----
From: Jan Beulich <jbeulich@suse.com>
Sent: Wednesday, April 1, 2026 2:37 PM
To: Filipovic, Bratislav <Bratislav.Filipovic@amd.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] binutils/readelf: Remove unused static variables

[You don't often get email from jbeulich@suse.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On 01.04.2026 13:09, Bratislav Filipovic wrote:
> Remove static variables do_ctf and do_sframe that are set but never
> read, causing build failures with LLVM's extended
> -Wunused-but-set-variable warning.
>
> These variables are dead code:
> - Declared at lines 244-245 as static booleans
> - Set to true when --ctf or --sframe options are parsed
> - Never actually used or read anywhere in the code
> - The actual dump functionality is triggered by request_dump() calls
>
> Build error with -Werror enabled:
> binutils/readelf.c:244:13: error: variable 'do_ctf' set but not used
>   [-Werror,-Wunused-but-set-variable]
> binutils/readelf.c:245:13: error: variable 'do_sframe' set but not used
>   [-Werror,-Wunused-but-set-variable]

Okay.

Jan