[PATCH v4 5/5] objdump: Add test on option --map-global-vars display global variable information
Jan Beulich
jbeulich@suse.com
Mon Sep 22 23:29:17 GMT 2025
On 23.09.2025 01:25, Jan Beulich wrote:
> On 09.09.2025 14:43, Guillaume VACHERIAS wrote:
>> Add test for the display of global variable information.
>> Single generic test that takes into account the data model
>> conventions (ILP32, LP64, ILP64, ILP64 and LLP64).
>>
>> binutils/testsuite/binutils-all
>>
>> * objdump-map-global-vars.c: New test.
>> * objdump.map-global-vars: New test.
>> * objdump.exp: Add new test.
>>
>> Signed-off-by: Guillaume VACHERIAS <guillaume.vacherias@foss.st.com>
>
> My v3 remarks weren't addressed verbally, and from eyeballing I also can't
> spot any change.
Hmm, I then recalled that the revision log is in patch 1 (rather than the
patch itself). From that it looks like you made some adjustments. Yet
especially for the ordering independence one I'm not quite convinced this
is suitable. You now wouldn't, afaict, fail if any unexpected output
appeared.
Jan
More information about the Binutils
mailing list