[committed] arm: Rename some tests to avoid duplicate tests names
Richard Earnshaw (lists)
Richard.Earnshaw@arm.com
Tue Sep 16 13:42:30 GMT 2025
On 16/09/2025 00:08, Hans-Peter Nilsson wrote:
> On Mon, 15 Sep 2025, Richard Earnshaw wrote:
>> A number of arm-specific tests print the same name. This can cause problems
>> if one of those tests fails, since then comparing tests with GCC's
>> compare_tests script can result in ambiguities in the changes summary.
>>
>> Avoid this by giving tests unique names.
>
> Another way to solve that, is to not use the "#name:" clause at
> all, so that the name defaults to the .d filename. They're
> pretty unique, and as a bonus it's easier to find the test
> whenever it's failing.
>
> I know, it's a matter of taste, so: "just saying". ;)
>
> brgds, H-P
That might be better for new tests, but I was trying to avoid any unnecessary churn in the results. It's relatively easy to look at, say:
Changes to non-unique test names:
- 2 PASS: arm-qemu/-mthumb: gas: ARM V6 instructions
New tests that PASS (60 tests):
arm-qemu/-mthumb: gas: ARM V6zk instructions
Old tests that passed, that have disappeared (60 tests): (Eeek!)
arm-qemu/-mthumb: gas: ARM V6 instructions
and see that this is a simple test rename. It's much harder if the new test name is
New tests that PASS (60 tests):
arm-qemu/-mthumb: arm/arch6zk.d
especially if there are many tests changing at once.
R.
More information about the Binutils
mailing list