[PATCH 1/1] Correct -Ue output for nm, objdump and readelf, like PR33360 does for strings.

Jan Beulich jbeulich@suse.com
Mon Sep 8 14:15:06 GMT 2025


On 08.09.2025 15:30, Andrew C Aitchison wrote:
> On Mon, 8 Sep 2025, Jan Beulich wrote:
> 
>> On 05.09.2025 20:02, Andrew C Aitchison wrote:
>>> Signed-off-by: Andrew C Aitchison <github@aitchison.me.uk>
>>> ---
>>>  binutils/nm.c      | 4 ++--
>>>  binutils/objdump.c | 4 ++--
>>>  binutils/readelf.c | 4 ++--
>>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> Much like the strings change this is okay to put in, while at the same time
>> I think we want to move to what you described in another reply, uniformly
>> using \unnnn and \Unnnnnnnn. I'm further wondering whether going just up to
>> 4 input chars in the functions is actually sufficient. Aiui in all four
>> instances at least a sanity check is missing, guarding against us treating
>> a 5- or more char sequence as a 4-char one, breaking the stream of bytes.
>>
>> Aiui this wants committing on your behalf?
> 
> Yes please, but I note in the other thread
> https://sourceware.org/pipermail/binutils/2025-September/144078.html
> that Alice has spotted other problems and is working on a series of patches.

Right, I'm aware. As per what Alan said for the strings patch, I think we
want to take this right away, and then other stuff can go on top. Such
later changed may then also be easier to review, when all four places are
sufficiently similar.

Jan


More information about the Binutils mailing list