[PATCH v2] libsframe: testsuite: Fix testsuite build on Solaris

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Fri Sep 5 11:25:02 GMT 2025


Hi Alan,

>> Thanks for taking care of this.
>>
>> sframe-test.h in toplevel include/ looks odd IMO.  Adding to
>> libsframe/testsuite/ folder along with the -I${top_srcdir}/testsuite
>> addition in libsframe/testsuite/libsframe.decode/local.mk,
>> libsframe/testsuite/libsframe.encode/local.mk,
>> libsframe/testsuite/libsframe.find/local.mk may be a better thing to do.
>
> I thought about this, but this seems like lots of duplication to me.
> Besides, these files are extremly repetetive, doing the same over and
> over again.  I wonder if this cannot be simplified, avoiding the massive
> duplication to improve maintainablitly?  Let's see what Alan thinks
> about this.

any word on how to handle this.  The current duplication worries me,
especially for a patch that tries to reduce duplication in one place
increasing duplication even more in a different place.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the Binutils mailing list