[PATCH v2] readelf: Handle 0 sh_entsize of GOT sections for x86

Jan Beulich jbeulich@suse.com
Thu Sep 4 13:13:34 GMT 2025


On 04.09.2025 15:08, H.J. Lu wrote:
> On Wed, Sep 3, 2025 at 11:05 PM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 04.09.2025 03:02, H.J. Lu wrote:
>>> --- a/binutils/readelf.c
>>> +++ b/binutils/readelf.c
>>> @@ -21150,6 +21150,30 @@ process_got_section_contents (Filedata * filedata)
>>>         }
>>>
>>>       uint32_t entsz = section->sh_entsize;
>>> +     /* NB: Some linker sets sh_entsize to 0 on .got and .got.plt
>                                             ^^^^^^^^^^^^^^^^^^^^
>>> +        sections, for example x86-64 Google chrome browser.  */
>>
>> Didn't you say you would adjust this comment, as per Alan's remark?
> 
> See ^^^^^^^^^^^^^^^^^^^^ above.

Except that Alan's wording was not only different, but also better grammar-
wise ("Some linkers set ...", if already you don't like the "don't" that
he used). I'm also puzzled by a browser being a linker.

Jan


More information about the Binutils mailing list