[PATCH v3 1/5] Add suitable defines to use at call and use sites

[Jan Beulich]

On 01.09.2025 19:50, Guillaume VACHERIAS wrote:
> Add missing ChangeLog entries and correctly set and clear do_flags anew
> for do_type cases. Is this ok for trunk ?

In principle yes, yet there are still cosmetics. First, repeating my v2
comment:

> Changes since v1:
> - Added new prerequisite patch to better handle call and use sites.
> - Change function process_debug_info arguments bool to unsigned int.
> - Change option name to "--map-global-vars" instead of "-Y/--map-file".
> - Added information on DWARF dependencues of this option.
> - Correct switch-case braces alignment.
> - Correct type of structure container field holding DW_AT_name from
> (unsigned char *) to plain text (char *).
> - Change to sizeof (<expression>) to avoid risk of variable's types being
> changed.
> - Replace error messages with asserts.
> - Rename enumeration identifier UNKNOWN to UNKNWON_TYPE to be less generic.
> - Remove unnecessary typedef aliases.
> 
> Changes since v2:
> - Fix defines DO_LOC and DO_TYPES values to lower-case x-exes.
> - Correctly set and clear do_flags anew.
> - Remove unnecessary parenthesis.
> 
> ---

The above isn't supposed to go into the eventual commit, is it? In its place
(more precisely, ahead of it, followed by a --- separator) a non-empty
description would be nice. Even if it's only a single sentence saying why
the change is being done. That, after all, ...

> binutils/
> 
> 	* dwarf.c (DO_LOC, DO_TYPES): Define.
> 	(process_debug_info): Change arguments do_loc and do_types
> 	to a single unsigned int do_flags.
> 	(find_cu_tu_set_v2): Change parameter do_types from int to bool.

... isn't being expressed by ChangeLog entries.

Furthermore, with the ChangeLog entry above part of the commit message, ...

> --- a/binutils/ChangeLog
> +++ b/binutils/ChangeLog
> @@ -1,3 +1,9 @@
> +2025-09-01  Guillaume Vacherias <guillaume.vacherias@foss.st.com>
> +	* dwarf.c (DO_LOC, DO_TYPES): Define.
> +	(process_debug_info): Change arguments do_loc and do_types
> +	to a single unsigned int do_flags.
> +	(find_cu_tu_set_v2): Change parameter do_types from int to bool.
> +
>  2025-07-13  Nick Clifton  <nickc@redhat.com>
>  
>  	* 2.45 Branch point.

... I don't think you should be modifying this file directly anymore. Which
is kind of supported by there not having been any new entries since the 2.45
release.

Jan