[PATCH v9 05/19] gas: use common code for object attribute v1 & v2 parsing
Jan Beulich
jbeulich@suse.com
Thu Oct 30 15:33:45 GMT 2025
On 01.09.2025 18:56, Matthieu Longo wrote:
> Since the previous patch added all the code to be able to parse both
> OAv1 and OAv2 directives, this patch switches OAv1 to use this common
> code.
> Additionally to the common code in obj-elf.c, the following backends
> using a custom object attribute directive were impacted.
> - ARC
> - Arm
> - m68k
> - PowerPC
> - RISC-V
> - TI C6X
> A parsing test for Arm had to be adapted to the error messages of the
> new parser.
>
> The gas and ld test suites were successfully run for the following
> backends: S390, ARC, Arm, CSky, m68k, msp430, PowerPC, TI C6X, RISC-V,
> AArch64, MIPS, SPARC.
> ---
> gas/config/obj-elf-attr.c | 116 ----------------------------
> gas/config/obj-elf-attr.h | 5 --
> gas/config/obj-elf.c | 5 --
> gas/config/tc-arc.c | 2 +-
> gas/config/tc-arm.c | 2 +-
> gas/config/tc-m68k.c | 2 +-
> gas/config/tc-ppc.c | 2 +-
> gas/config/tc-riscv.c | 2 +-
> gas/config/tc-tic6x.c | 2 +-
> gas/testsuite/gas/arm/attr-syntax.d | 6 +-
> 10 files changed, 11 insertions(+), 133 deletions(-)
Looks good to me, but likely will want at least an Arm maintainer ack (the other
arch-specific changes are mechanical enough).
Jan
More information about the Binutils
mailing list