[COMMITTED, PATCH] elf: Drop the FIXME comment in set_symbol_value

[H.J. Lu]

On Sat, Oct 25, 2025 at 3:11 AM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
> On Tue, 23 Sep 2025, H.J. Lu via Binutils-cvs wrote:
>
> > diff --git a/bfd/elflink.c b/bfd/elflink.c
> > index 66982f82b94..54f0d6e957e 100644
> > --- a/bfd/elflink.c
> > +++ b/bfd/elflink.c
> > @@ -9188,11 +9194,12 @@ set_symbol_value (bfd *bfd_with_globals,
> >    if (h == NULL)
> >      {
> >        /* FIXMEL What should we do ?  */
> > -      return;
> > +      return false;
>
>  Shouldn't that FIXMEL (sic!) comment be removed now, now that we handle
> the error situation correctly?
>
>   Maciej

Sure.  I am checking this in:

Since

commit aeaaa9af6359c8e394ce9cf24911fec4f4d23703
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 23 08:52:26 2025 +0800

    elf: Return error on unsorted symbol table if not allowed

returns false when get_link_hash_entry returns NULL, we can drop the FIXME
comment now.

PR ld/33450
* elflink.c (set_symbol_value): Drop the FIXME comment.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-elf-Drop-the-FIXME-comment-in-set_symbol_value.patch
Type: text/x-patch
Size: 1248 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20251025/5ed5bf2a/attachment.bin>