[committed] hppa64: Remove a couple of unnecessary NULL pointer checks

John David Anglin dave.anglin@bell.net
Wed Oct 15 21:11:08 GMT 2025


Committed to master.

Dave
---

hppa64: Remove a couple of unnecessary NULL pointer checks

2025-10-15  John David Anglin  <danglin@gcc.gnu.org>

bfd/ChangeLog:

	* elf64-hppa.c (allocate_global_data_opd): Remove hh check.
	(elf64_hppa_finalize_dlt): Likewise.

diff --git a/bfd/elf64-hppa.c b/bfd/elf64-hppa.c
index 74f59fa85db..6a63ce2cc12 100644
--- a/bfd/elf64-hppa.c
+++ b/bfd/elf64-hppa.c
@@ -1079,7 +1079,7 @@ allocate_global_data_opd (struct elf_link_hash_entry *eh, void *data)
   struct elf64_hppa_link_hash_entry *hh = hppa_elf_hash_entry (eh);
   struct elf64_hppa_allocate_data *x = (struct elf64_hppa_allocate_data *)data;
 
-  if (hh && hh->want_opd)
+  if (hh->want_opd)
     {
       /* We never need an opd entry for a symbol which is not
 	 defined by this output file.  */
@@ -2230,11 +2230,7 @@ elf64_hppa_finalize_dlt (struct elf_link_hash_entry *eh, void *data)
   sdlt = hppa_info->dlt_sec;
   sdltrel = hppa_info->dlt_rel_sec;
 
-  /* H/DYN_H may refer to a local variable and we know it's
-     address, so there is no need to create a relocation.  Just install
-     the proper value into the DLT, note this shortcut can not be
-     skipped when building a shared library.  */
-  if (! bfd_link_pic (info) && hh && hh->want_dlt)
+  if (! bfd_link_pic (info) && hh->want_dlt)
     {
       bfd_vma value;
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20251015/07b0dfca/attachment.sig>


More information about the Binutils mailing list