[PATCH v2 2/5] gas: aarch64: Add instructions for GICv5

[Alice Carlotti]

On Mon, Oct 06, 2025 at 03:40:04PM +0100, saurabh.jha@arm.com wrote:
> From: Saurabh Jha <saurabh.jha@arm.com>
> 
> Add new instructions from the Generic Interrupt Controller, GICv5,
> extension. These instructions are aliases to system instructions and are
> the following:
> 
> * gic <operation>, <reg>
> * gicr <reg>, <operation>
> * gsb <operation>
...
> diff --git a/gas/testsuite/gas/aarch64/gcie.s b/gas/testsuite/gas/aarch64/gcie.s
> new file mode 100644
> index 00000000000..d7eb8e1721b
> --- /dev/null
> +++ b/gas/testsuite/gas/aarch64/gcie.s
> @@ -0,0 +1,113 @@
...
> +
> +	// GSB SYS
> +	gsb	sys
> +
> +	// GSB ACK
> +	gsb	ack

Could you add tests for invalid gsb variants, i.e:

+ 	// Don't disassemble gsb with nonzero Rt.
+ 	sys #0, c12, c0, #0, x0
+ 	sys #0, c12, c0, #1, x0

(and matching changes to the .d file, of course).

Also, one more nit - patches 2-5 affect more than just gas, so it would make
sense to drop "gas: " from your commit title.

The series is ok with these changes, thanks.

Alice