[PATCH v3] gdb/hppa: guess g packet size
Simon Marchi
simark@simark.ca
Mon Nov 10 21:38:25 GMT 2025
On 11/10/25 4:34 PM, Sven Schnelle wrote:
> Simon Marchi <simark@simark.ca> writes:
>
>>> + warning (_("target returned a target description this gdb doesn't "
>>> + "support for the HP/PA architecture"));
>>
>> Good idea to put out a warning. I would suggesting some minor changes
>> to the message:
>>
>> warning (_("The target returned a target description but this gdb "
>> "doesn't support target descriptions for the HP/PA
>> "architecture"));
>>
>> Just thinking out loud: it would actually be nice to have this warning
>> for all architectures that don't support target descriptions, if there
>> was a way to put it at a single common place.
>>
>> Other than that, the patch looks fine.
>>
>> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>>
>> Do you have push access or would you like me to push the patch on your
>> behalf (with the modification proposed above)?
>
> I don't have push acess - would appreciate if you could adjust the
> message and push it.
Done, thanks. I even extended the message to:
warning (_("The target returned a target description but this GDB "
"doesn't support target descriptions for the HP/PA"
"architecture. Assuming standard 32-bit register"
"layout."));
Simon
More information about the Binutils
mailing list