[PATCH v2 03/10] BFD: Rename `*_set_reloc' to `*_finalize_section_relocs'
Maciej W. Rozycki
macro@orcam.me.uk
Mon Nov 10 16:34:00 GMT 2025
On Mon, 10 Nov 2025, Jan Beulich wrote:
> > The prototype is generated as a side effect of parsing a comment block
> > that serves as a manual entry to document this API. While the API is
> > handled by a macro now, I think the intended data types for the macro's
> > arguments and the return type still need to be documented. The use of a
> > macro rather than a function is an implementation detail (and frankly it
> > should possibly be converted to a static inline function indeed), and I
> > find showing the interface in terms of a function prototype the right way
> > to do this.
>
> Just one further remark here: See how converting to an inline function
> (as long as you mean a static inline one) would then collide with the
> prototype that's there?
Why would it? The prototype would just have to be adjusted accordingly
(I can't be bothered to check whether the documentation conversion script
strips specifiers from function prototypes nor think whether it should).
NB I wrote "a static inline function," so why should I mean anything but
a static inline function?
Maciej
More information about the Binutils
mailing list