[PATCH] ld: Fix a H8/300 specific test case

Alan Modra amodra@gmail.com
Mon Nov 10 00:17:17 GMT 2025


On Fri, Nov 07, 2025 at 07:55:19AM +0100, Jan Dubiec wrote:
> 
> One of the H8/300 specific ld test cases fails, regardless whether it is run
> on Linux or Windows/MSYS2:

It works here for me on Linux.  I think the patch is good though, and
will commit it with a modified log message.

> [...]
> /d/Works/xcomp/build-binutils-h8300-mingw/ld/../gas/as-new     -o
> tmpdir/relax-7?.o /d/Works/binutils/ld/testsuite/ld-h8300/relax-7?.s
> Executing on host: sh -c
> {/d/Works/xcomp/build-binutils-h8300-mingw/ld/../gas/as-new     -o
> tmpdir/relax-7?.o /d/Works/binutils/ld/testsuite/ld-h8300/relax-7?.s 2>&1}
> /dev/null dump.tmp (timeout = 300)
> spawn [open ...]
> Assembler messages:
> Fatal error: can't create tmpdir/relax-7?.o: Invalid argument
> failed with: <Assembler messages:
> Fatal error: can't create tmpdir/relax-7?.o: Invalid argument>, no expected
> output
> FAIL: H8300 Relaxation Test 7
> 
> It seems that glob patterns no longer work in the test suite. However,
> according to the run_dump_test documentation, it is possible to specify
> multiple "source" options in a pattern file (.d). So does the attached
> patch.
> 
> /J.D.
> 
> ld/
>     * testsuite/ld-h8300/relax-7.d: Replace the nonfunctional glob
>     pattern with multiple "source" options.
> 
> Signed-off-by: Jan Dubiec <jdx@o2.pl>

>  ld/testsuite/ld-h8300/relax-7.d | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ld/testsuite/ld-h8300/relax-7.d b/ld/testsuite/ld-h8300/relax-7.d
> index 9bd68626c77..f45787c75ce 100644
> --- a/ld/testsuite/ld-h8300/relax-7.d
> +++ b/ld/testsuite/ld-h8300/relax-7.d
> @@ -1,5 +1,6 @@
>  # name: H8300 Relaxation Test 7
> -# source: relax-7?.s
> +# source: relax-7a.s
> +# source: relax-7b.s
>  # ld: --relax
>  # objdump: -d -s --no-show-raw-insn
>  


-- 
Alan Modra


More information about the Binutils mailing list